Closed Bug 965093 Opened 12 years ago Closed 12 years ago

Re-enable browser related gaia unit tests on tbpl

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.3 C3/1.4 S3(31jan)

People

(Reporter: gwagner, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/15864
46 bytes, text/x-github-pull-request
benfrancis
: review+
Details | Review
Or move them to the systems app once the browser app moves or remove completely? I disabled them in bug 965083 in order to unhide all passing tests on tbpl. 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | Date Helper started todayStarted | DateHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: DateHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:16) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | Date Helper started yesterdayStarted | DateHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: DateHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:26) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | Date Helper started thisWeekStarted | DateHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: DateHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:35) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | Date Helper started thisMonthStarted | DateHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: DateHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:44) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | Date Helper started lastSixMonthsStarted | DateHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: DateHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:54) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | Date Helper started thisYearStarted | DateHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: DateHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:63) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-END | browser/test/unit/utilities_test.js | started 16:15:08 INFO - gaia-unit-tests TEST-END | browser/test/unit/utilities_test.js | Date Helper 16:15:08 INFO - gaia-unit-tests TEST-START | browser/test/unit/utilities_test.js | HTML Helper 16:15:08 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | browser/test/unit/utilities_test.js | HTML Helper createHighlightHTML | HtmlHelper is not defined 16:15:08 INFO - gaia-unit-tests INFO | stack trace: 16:15:08 INFO - ReferenceError: HtmlHelper is not defined 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/test/unit/utilities_test.js:79) 16:15:08 INFO - at wrapper (http://browser.gaiamobile.org:8080/common/test/mocha_generators.js:62) 16:15:08 INFO - at run (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 16:15:08 INFO - at runTest (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 16:15:08 INFO - at next (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 16:15:08 INFO - at (anonymous) (http://browser.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) 16:15:08 INFO - gaia-unit-tests TEST-END | browser/test/unit/utilities_test.js | HTML Helper 16:15:08 INFO - gaia-unit-tests TEST-END | browser/test/unit/utilities_test.js |
Whiteboard: [systemsfe]
Was likely broken by me moving utilities into shared, will fix up the utilities thing and I think the browser_db tests should just die with the browser
Assignee: nobody → dale
Attachment #8368522 - Flags: review?(bfrancis)
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
Comment on attachment 8368522 [details] [review] https://github.com/mozilla-b2g/gaia/pull/15864 This looks good to me, just wait for Travis to pass before merge.
Attachment #8368522 - Flags: review?(bfrancis) → review+
https://github.com/mozilla-b2g/gaia/commit/e451289f9574056b00c3bef6c348cd62291feb18
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: