965127 - mach gets confused with relative pathnames

Status: NEW

(Firefox Build System :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If I do:

cd inbound
mkdir obj-foo
cd obj-foo
MOZCONFIG=../../configs/debug ../configure
mozmake -s -j8

it will blow up with an issue during export, as in http://hastebin.com/denuwoyura .  mozinfo.json has an incorrect path to mozconfig -- it somehow resolved the "../.." relative to the srcdir, not the objdir that I was in, and then recorded that in mozinfo.json.

I suspect this is breaking various other usage of mach as well; I've been trying to use it but it's pretty painful to do so on Windows for anything other than the most basic default builds.

Specifying an absolute path is unfortunately not an option -- there's no sense in forcing people to use MOZCONFIG=/c/Users/vladimir/mozilla/config/debug (or even the same on osx/linux!), when relative paths have worked forever before.  If absolute paths are required, the objdir should force things to absolute as needed -- either mach or configure should do that before invoking things further.

Comment 1

[Mike Hommey [:glandium]]

There are two problems in your log: the relative path one, and the fact that we're loading the mozconfig to do webidl processing...

Comment 2

[Gregory Szorc [:gps]]

mozinfo.json doesn't reference the mozconfig - what path inside mozinfo.json is incorrect?

Yes, mozconfig loading during webidl processing shouldn't occur. It's happening because MozbuildObject.from_environment() is called and something is incurring lazy resolution of a value the build system thinks it needs mozconfigs to resolve. We should have a separate code path for reading some configure/config.status-derived file instead.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Let's reuse this bug, since the core issue is still valid.  (On Windows as usual)

# mkdir objdir
# cd objdir
# MOZCONFIG=../someconfig ../mozilla-central/configure
# ../mozilla-central/mach build

this starts re-configuring a new objdir in ../mozilla-central/obj-blah-blah, when it should just do a build in the current directory.

mozinfo.json has appropriate absolute path names.  Just running make ("mozmake -s -j8") manually works fine.

This looks like an issue in client.mk.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Any more thoughts on this? I keep wanting to use mach, but this makes it impossible.

Comment 5

[Gregory Szorc [:gps]]

I'm unable to work on build patches until at least other more important work is complete.

Staffing for this type of work is hard to come by right now. Most of the effort is being invested into cloud-y aspects of build.

As they say, "patches welcome."