Closed Bug 965144 Opened 6 years ago Closed 6 years ago

Make sure the Window-specific bits of XrayWrapper work with WebIDL Window

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch I think this should do the trick (obsolete) — Splinter Review
Attachment #8367140 - Flags: review?(bobbyholley)
Also, while I was here... seems to me like we can replace do_QueryInterfaceNative with an UNWRAP_OBJECT(Element, wrapper, content) or so.  Agreed?
Whiteboard: [need review]
Blocks: 965153
Attachment #8367140 - Attachment is obsolete: true
Attachment #8367140 - Flags: review?(bobbyholley)
Comment on attachment 8367396 [details] [diff] [review]
Make the Window-specific bits of XrayWrapper work with WebIDL windows.

Review of attachment 8367396 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +673,5 @@
> +  JSObject* target = XrayTraits::getTargetObject(wrapper);
> +  nsresult rv = UNWRAP_OBJECT(Window, target, win);
> +  if (NS_SUCCEEDED(rv)) {
> +      return win;
> +  }

Nit - no braces in XPConnect.
Attachment #8367396 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/78767e93ff14 with that fixed.
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/78767e93ff14
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.