965144 - Make sure the Window-specific bits of XrayWrapper work with WebIDL Window

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: I think this should do the trick

Comment 2

[Boris Zbarsky [:bzbarsky]]

Also, while I was here... seems to me like we can replace do_QueryInterfaceNative with an UNWRAP_OBJECT(Element, wrapper, content) or so.  Agreed?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the Window-specific bits of XrayWrapper work with WebIDL windows.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8367396 [details] [diff] [review]
Make the Window-specific bits of XrayWrapper work with WebIDL windows.

Review of attachment 8367396 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +673,5 @@
> +  JSObject* target = XrayTraits::getTargetObject(wrapper);
> +  nsresult rv = UNWRAP_OBJECT(Window, target, win);
> +  if (NS_SUCCEEDED(rv)) {
> +      return win;
> +  }

Nit - no braces in XPConnect.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78767e93ff14 with that fixed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78767e93ff14