965154 - Make the global scope polluter work with WebIDL Window

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Just need to fix how it gets the window from the global.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the global scope polluter handle WebIDL Window objects.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8367147 [details] [diff] [review]
Make the global scope polluter handle WebIDL Window objects.

Review of attachment 8367147 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/WindowNamedPropertiesHandler.cpp
@@ +9,5 @@
>  #include "nsGlobalWindow.h"
>  #include "nsHTMLDocument.h"
>  #include "nsJSUtils.h"
>  #include "xpcprivate.h"
> +#include "mozilla/dom/WindowBinding.h"

Nit: this list of includes is sorted

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 8367147 [details] [diff] [review]
Make the global scope polluter handle WebIDL Window objects.

Review of attachment 8367147 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/WindowNamedPropertiesHandler.cpp
@@ +101,5 @@
>  
>    nsDependentJSString str(aId);
>  
>    // Grab the DOM window.
> +  nsGlobalWindow* win = GetWindowFromGlobal(global);;

Redundant semicolon.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed both nits and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3910ec9bec17

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3910ec9bec17