965176 - In about:apps, lost the ability to invoke a context menu on an installed application

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P3)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Build: Firefox for Android 29.0a1 (2013-01-28)
Device: Samsung Galaxy Tab 2 (Android 4.2.2)

Steps to reproduce:
1. Go to https://marketplace.firefox.com
2. Install an application
3. Go to about:apps
4. Long tap on the installed application

Expected results:
- After long-tapping, a context menu should be triggered

Actual results:
- After long-tapping, it triggers text selection mode.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

We disabled the context menu intentionally, so the original summary of this bug is more accurate.  But we might reenable it (although we have no specific plans to do so yet), which would fix both summaries.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Over time I've come to think that we should reenable this menu and allow users to uninstall from this interface, even though there is also a native interface for uninstalling, because:

1. Some users will expect to be able to uninstall from any interface that shows a list of apps, and we should satisfy those expectations, even if it means providing the same function in multiple places.  After all, Android itself provides multiple interfaces for uninstalling apps, and generally speaking, many interface designs provide the same (f.e. keyboard shortcuts and menu items).

2. It's theoretically possible for DOMApplicationRegistry to get out of sync with the list of installed APKs, such that the registry thinks there's an app installed, but there's no APK installed for that app.  And we've already experienced a bug that resulted in that behavior.  When it happens, there's currently no way to uninstall the app, but there should be, and fixing this would provide that way.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - What's the ETA for this? Does it require strings?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Does it require strings?

It shouldn't require strings, as the menu was just disabled:

https://github.com/mozilla/gecko-dev/blob/e3e1f9ec39aa5bbaea870234d1631fdfbde4a495/mobile/android/chrome/content/aboutApps.xhtml#L32-L37

And its strings are still present:

https://github.com/mozilla/gecko-dev/blob/e3e1f9ec39aa5bbaea870234d1631fdfbde4a495/mobile/android/locales/en-US/chrome/aboutApps.dtd#L9-L10

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Bug 957065 would make this easier to fix.

Comment 8

[Aravind]

Since my bug 1017809 is marked as duplicate, I just want to let you know that the webapp is not listed in Android Settings -> Apps.

Also, checked the output of "pm list packages" using adb. I can't find the web app there also.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

(In reply to Aravind from comment #8)
> Since my bug 1017809 is marked as duplicate, I just want to let you know
> that the webapp is not listed in Android Settings -> Apps.
> 
> Also, checked the output of "pm list packages" using adb. I can't find the
> web app there also.

Did you install the app with an older version of Firefox by any chance?  If so, you may be able to uninstall it by tapping the "Check for Updates…" item, updating the app when prompted to do so, and then uninstalling the app from Android's All Apps screen or Android Settings > Apps.

Comment 10

[Aravind]

Attachment: firefox errors from launch to clicking check for updates in Tools -> Apps

Comment 11

[Aravind]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #9)
> (In reply to Aravind from comment #8)
> > Since my bug 1017809 is marked as duplicate, I just want to let you know
> > that the webapp is not listed in Android Settings -> Apps.
> > 
> > Also, checked the output of "pm list packages" using adb. I can't find the
> > web app there also.
> 
> Did you install the app with an older version of Firefox by any chance?  If
> so, you may be able to uninstall it by tapping the "Check for Updates…"
> item, updating the app when prompted to do so, and then uninstalling the app
> from Android's All Apps screen or Android Settings > Apps.

I think I installed the web app before upgrading firefox. Anyways, I tried clicking Check for updates...

NOTHING HAPPENS. I have attached the logs by doing adb logcat *:W | grep -i gecko.

Comment 12

[Myk Melez [:myk] [@mykmelez]]

(In reply to Aravind from comment #11)
> I think I installed the web app before upgrading firefox. Anyways, I tried
> clicking Check for updates...
> 
> NOTHING HAPPENS. I have attached the logs by doing adb logcat *:W | grep -i
> gecko.

I don't see anything noteworthy in the log, but let's discuss outside of the context of this bug.  I'll send you an email to troubleshoot further.

Comment 13

[Myk Melez [:myk] [@mykmelez]]

We reintroduced this menu in bug 1019054, resolving this issue.