965238 - --disable-accessibility build fails with: layout/xul/nsMenuFrame.cpp:682:64: error: no member named 'anonid' in 'nsGkAtoms'

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Mats Palmgren (inactive)]

layout/xul/nsMenuFrame.cpp:682:64: error: no member named 'anonid' in 'nsGkAtoms'
      doc->GetAnonymousElementByAttribute(mContent, nsGkAtoms::anonid, id);
                                                    ~~~~~~~~~~~^

Comment 1

[Mats Palmgren (inactive)]

Looks like bug 941409 broke this.  I guess we need to move "anonid"
out of the "#ifdef ACCESSIBILITY" block in nsGkAtomList.h.

Comment 2

[:Gijs (he/him)]

Attachment: trivial patch to move anonid atom out of a11y ifdef,

This should do the trick, right?

Comment 3

[Neil Deakin]

Comment on attachment 8367301 [details] [diff] [review]
trivial patch to move anonid atom out of a11y ifdef,

Yes, let's just fix this

Comment 4

[:Gijs (he/him)]

I should read bugmail better. Anyhow:

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/523a1736de8f

And then backed out and relanded to fix the commit msg:

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/866823b9979e
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/97540c3ca68d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97540c3ca68d