965248 - "Top Crashing Signatures For Bug" only displays one product/version row per signature

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

The "Top Crashing Signatures For Bug X" feature introduced by bug 915373 did get some nice improvements in 72, but it also regressed to not show more than one product/version row per signature any more.

See for example those two that are for sure present in multiple versions and (in the former case) products for sure: https://crash-stats.mozilla.com/topcrasher_ranks_bybug/?bug_number=711568 https://crash-stats.mozilla.com/topcrasher_ranks_bybug/?bug_number=530074

Comment 1

[Robert Helmer [:rhelmer]]

Thanks for catching that, I suspect it is a regression from bug 952246

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: handle multiple product+versions per signature

Turns out we *do* need to include all matching results from TCBS (you had asked about that in the review where I introduced this, alas)

Comment 3

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #2)
> Turns out we *do* need to include all matching results from TCBS (you had
> asked about that in the review where I introduced this, alas)

IIRC, I asked for not including results for products/versions where we do not have a rank - but we sure need to include all that have a (top-300) rank.

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> (In reply to Robert Helmer [:rhelmer] from comment #2)
> > Turns out we *do* need to include all matching results from TCBS (you had
> > asked about that in the review where I introduced this, alas)
> 
> IIRC, I asked for not including results for products/versions where we do
> not have a rank - but we sure need to include all that have a (top-300) rank.

Yep still excluding these! Only "active" (non-expired) releases are pulled from TCBS.

Comment 5

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #4)
> Yep still excluding these! Only "active" (non-expired) releases are pulled
> from TCBS.

Sounds perfect! :)

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d14205a19d91be99a58c70cd7e3ffe178478e213
fixes bug 965248 - handle multiple products per signature

https://github.com/mozilla/socorro/commit/0a605dc2b26c71b3a9e271d151d01d7a9ffe7260
Merge pull request #1838 from rhelmer/bug965248-top-crashing-bugs-not-showing-multiple-products

fixes bug 965248 - handle multiple products per signature

Comment 7

[Robert Helmer [:rhelmer]]

The staging-equivalent URLs from comment 0 should have multiple products and versions per signature, instead of just one (compare to production)