965250 - Fix TextureHostD3D9

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

The new TextureHostD3D9 isn't properly copying the texture sent from the client.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Fix TextureHostD3D9

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8367297 [details] [diff] [review]
Fix TextureHostD3D9

Review of attachment 8367297 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d9/TextureD3D9.cpp
@@ -1537,5 @@
>      mSize.height = desc.Height;
>    }
>  }
>  
> -TextureHostD3D9::TextureHostD3D9(TextureFlags aFlags)

Why are we removing this constructor? That isn't clear to me.

::: gfx/layers/d3d9/TextureD3D9.h
@@ +355,5 @@
>    TextureHostD3D9(TextureFlags aFlags);
>    IDirect3DDevice9* GetDevice();
>  
>    RefPtr<DataTextureSourceD3D9> mTextureSource;
> +  IDirect3DTexture9* mTexture;

This can't possible be good....

Comment 3

[Nicolas Silva [:nical]]

Attachment: Updated patch

Comment 4

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16d9ad02098a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16d9ad02098a