965345 - Remove test-run query

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Mark Côté [:mcote]]

Since deploying bug 909368, when you look at the details of a bug, e.g. http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=934938&startday=2014-01-22&endday=2014-01-29&tree=trunk an error dialog pops up saying "200: OK"... which is not an error.  I can't reproduce this locally.

Comment 1

[Mark Côté [:mcote]]

Doesn't seem to happen if you go directly to the link above, but it does happen if you go from another Orange Factor page via a bug [details] link.  Wonder if it has something to do with aborting an on-going AJAX request.  I'll file a separate bug for that.

Comment 2

[Mark Côté [:mcote]]

According to the web console and running the problematic URL through curl, the actual error is 414 Request-URI Too Large.  Indeed, we're doing a call to api/testrun with an enormous URL.  I have no idea why this is showing up as a 200 OK, and I still don't know why I can't reproduce it locally.  It could have something to do with nginx vs the local dev server, but that doesn't explain why the error doesn't show up when loading from a file:/// URL, which should use the server on brasstacks.

I would like to figure out why the error isn't being displayed properly, but it is more important to either stop doing these queries (not sure how useful they are anymore anyway) or split them up or use a POST body or something.

Comment 3

[Mark Côté [:mcote]]

Okay seems that the server isn't actually returning a 414; rather, it's returning an error message in HTML with a 200 OK.  This is causing the error callback to be invoked because dataType is set to 'json', so the parser fails when it gets the HTML error message.  There is no obvious way to determine that the request failed due to a 414 aside from trying to interpret the HTML.

So I think we should just fix these too-long queries, since the 414-error problem seems to be on the server, and I don't think it's worth trying to work around on the client.  Updating summary appropriately.

Comment 4

[Mark Côté [:mcote]]

So these queries haven't even been working for a long time, probably as a result of bug 707319.  Before too long, we're moving star data to treeherder, so I don't think it's worth fixing now, if ever.  We need to revisit all of Orange Factor's functionality in light of treeherder anyway.  So changing this bug (again) to just removing the test-run queries.

Comment 5

[Mark Côté [:mcote]]

Attachment: bug-965345.diff

I removed the Bug Correlations view as well, which has also been broken forever.

Comment 6

[Mark Côté [:mcote]]

Pushed and deployed.

http://hg.mozilla.org/automation/orangefactor/rev/c551161df303