965386 - [B2G]The clock on the status bar disappears after using the camera from the lockscreen with passcode lock enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Andrew Stole [:astole]]

Attachment: Screenshot

Taking a picture with a passcode lock enabled, then unlocking the phone causes the clock on the homescreen to disappear.

Repro Steps:
1) Updated Buri to BuildID: 20140129004052
2) Lock the phone with a passcode enabled
3) Tap the camera icon on the lockscreen
4) Press home button
5) Unlock the phone

Actual:
The clock is no longer visible on the homescreen.

Expected:
The clock is visible on the homescreen after unlocking the phone.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140129004052
Gaia: b0aa74619cffb7a39ee0e7da5e9361a98e69f3f6
Gecko: 7d1173c4b173
Version: 28.0a2
Firmware Version: V1.2-device.cfg

Repro frequency: 100%
See attached: Screenshot

Comment 1

[Andrew Stole [:astole]]

This issue does not occur on the latest 1.2

Environmental Variables:
Device: (example: Buri v1.2 Mozilla RIL)
BuildID: 20140128004004
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: d10e1f965d0c
Version: 26.0
Firmware Version: V1.2-device.cfg

Comment 2

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131120040202
Gaia: c26480b22ce28c812c347290dd4bad090d83db6f
Gecko: 4f993fa378eb
Version: 28.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131121040202
Gaia: 71063dd91bc8cbb15ba335236ed67a1c5058bd58
Gecko: cf378dddfac8
Version: 28.0a1
Base Image: V1.2-device.cfg

Comment 3

[Preeti Raghunath(:Preeti)]

Gregor,

Please review from System perspective.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Confirmed on desktop. Looks like somehow this triggers a case where this.toggleTimeLabel doesn't get called.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Make lockscreen always fire unlock message when unlock happens

Currently trying to figure out who to assign this to since timdream is out.

Comment 6

[Anthony Ricaud (:rik)]

Comment on attachment 8368391 [details] [review]
Patch 1 (v1) - Make lockscreen always fire unlock message when unlock happens

Kyle: You can use https://wiki.mozilla.org/Modules/FirefoxOS to find module peers. I'm giving this to Étienne.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8368391 [details] [review]
Patch 1 (v1) - Make lockscreen always fire unlock message when unlock happens

I'll much rather fix the issue.

If you follow the STR, by the time we get to set the "unlocked" class on the overlay [1] it has the "no-transition" css class. No wonder why we don't get our transitionend :)

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L641

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v2) - Readd no-transition class when coming out of camera panel

We explicitly remove the no-transition class on the way to the camera panel, but we never add it back when we come out. This fixes that. Should be fine for just happening in main/passcode since there's no camera to emergency call transition flow available.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8368862 [details] [review]
Patch 1 (v2) - Readd no-transition class when coming out of camera panel

Awesome, thanks!

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/qdot/gaia/commit/848ca9499f7d860ebeb77010c8fb4fa417c3bc7d

Comment 11

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/commit/a9a4e7bbcf55d1bd0a0d441f7dcc6271cc2dc6b1

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted a9a4e7bbcf55d1bd0a0d441f7dcc6271cc2dc6b1 to:
v1.3: d67e086f2583b80223d1dffdef866dbef4720400