965461 - existing fxA user, restarting browser should indicate that it is signing into FxA service

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Edwin Wong [:edwong]]

1. sign into FxA
2. restart browser
3. look at Tools > Setup Sync menu item or pref > sync

actual: 
The first 3-8 sec
Fx will momentarily be signed out, then when authentication completes, you will be signed in.

expected: you should have UX that shows it signing into service or it should be faster.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to Edwin Wong [:edwong] from comment #0)
> expected: you should have UX that shows it signing into service or it should
> be faster.

We should just assume success and show an error state on failure, rather than introducing progress UI.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Mark says this doesn't always recover (i.e. sometimes it doesn't fix itself at all), which sounds worse and thus merits blocking bug 964922.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0005-Bug-965461-ensure-sync-itself-and-sync-prefs-pane-co.patch

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8367768 [details] [diff] [review]
0005-Bug-965461-ensure-sync-itself-and-sync-prefs-pane-co.patch

Review of attachment 8367768 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 5

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/2bfa24370b7c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/bec6cec02f28 along with the patch from bug 960887 because one or both of them broke xpcshell tests:
https://tbpl.mozilla.org/php/getParsedLog.php?id=33785490&tree=Fx-Team

Comment 7

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/2b4f723f6c60

Comment 8

[Carsten Book [:Tomcat]]

backed out this change in https://tbpl.mozilla.org/?tree=Fx-Team&rev=5a3bc41cd6f1 for causing broken XPCshell tests like https://tbpl.mozilla.org/php/getParsedLog.php?id=33794976&tree=Fx-Team

Comment 9

[Mark Hammond [:markh] [:mhammond]]

re-tweaked version landed, still with r=ttaubert

https://hg.mozilla.org/integration/fx-team/rev/79d112ec7aa6

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/79d112ec7aa6

Comment 11

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora