Closed
Bug 965472
Opened 10 years ago
Closed 10 years ago
Legacy sync link on about:accounts getting started page loads new link in same tab, losing the welcome screen
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 30
People
(Reporter: pdehaan, Assigned: markh)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file)
1.50 KB,
patch
|
ttaubert
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
via https://github.com/mozilla/fxa-content-server/issues/354 Steps to reproduce: 1. Go to "about:accounts". 2. Click the "Using Sync on an older version of Nightly?" link at the bottom of the page. Actual results: The link currently works and redirects to https://support.mozilla.org/en-US/kb/how-sync-works-old-version-firefox?as=u&utm_source=inproduct but it loads the mozilla support page in the same tab, so I'm no longer on about:accounts. Expected results: add `target="_blank"` or something to the anchor tag so the Mozilla Support link opens in a new tab.
Updated•10 years ago
|
Whiteboard: [qa+]
Comment 1•10 years ago
|
||
Incidentally, this is the link we're using for Android. https://support.mozilla.org/kb/use-sync-with-an-older-version-of-firefox Should we switch?
Assignee | ||
Comment 2•10 years ago
|
||
I thought it was a feature :) John, can you confirm if this should replace about:accounts or open a new tab? Change is trivial if that's what is wanted.
Flags: needinfo?(jgruen)
Comment 3•10 years ago
|
||
moving component
Updated•10 years ago
|
Component: Firefox Sync: UI → FxA
OS: Mac OS X → All
Product: Mozilla Services → Firefox
Hardware: x86 → All
Updated•10 years ago
|
Blocks: 969593, fxdesktopbacklog
Updated•10 years ago
|
Whiteboard: [qa+] → p=0 [qa+]
Assignee | ||
Comment 5•10 years ago
|
||
Updated•10 years ago
|
Attachment #8375304 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d34e01528ec9
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d34e01528ec9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Updated•10 years ago
|
No longer blocks: fxdesktopbacklog
Whiteboard: p=0 [qa+] → [qa+]
Updated•10 years ago
|
status-firefox29:
--- → affected
tracking-firefox29:
--- → +
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8375304 [details] [diff] [review] Open sumo article in a tab [Approval Request Comment] Bug caused by (feature/regressing bug #): Fxa Sync User impact if declined: about:accounts tab will be replaced if the user wants to read information about legacy sync support. Testing completed (on m-c, etc.): Landed on mc Risk to taking this patch (and alternatives if risky): Low String or IDL/UUID changes made by this patch: None
Attachment #8375304 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox30:
--- → fixed
Updated•10 years ago
|
Attachment #8375304 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•