Closed Bug 965498 Opened 6 years ago Closed 6 years ago
Bluetooth leaks every blob
aActor->GetBlob() returns already_AddRefed, which bluetooth is throwing away.
Attachment #8367558 - Flags: review?(kyle)
Attachment #8367558 - Flags: review?(kyle) → review+
With reviewer information.
6 years ago
blocking-b2g: --- → 1.3+
Yikes. Did you find this via pure code inspection or did profiling data point you in this direction?
bent noticed it while looking at a patch, I believe. There was some discussion at the DOM work week about eliminating this footgun (or at least making it more obvious than "get()"), but I'm not sure if a bug's been filed about it yet.
Yeah, bent found it while looking at a patch that moved this code around. We came up with a plan for catching these sorts of errors at the work week today. More to come. Also we really need to run b2g with leak checking turned on.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Not sure if this is considered "stability" enough to be considered for v1.2 uplift still. You'll want to run it past RelMan if you think this should be uplifted there still.
6 years ago
You need to log in before you can comment on or make changes to this bug.