965498 - Bluetooth leaks every blob

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

aActor->GetBlob() returns already_AddRefed, which bluetooth is throwing away.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This was introduced in bug 817972.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

With reviewer information.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/464a1e7fb0d9

Comment 4

[Nicholas Nethercote [inactive]]

Yikes. Did you find this via pure code inspection or did profiling data point you in this direction?

Comment 5

[Andrew McCreight [:mccr8]]

bent noticed it while looking at a patch, I believe.  There was some discussion at the DOM work week about eliminating this footgun (or at least making it more obvious than "get()"), but I'm not sure if a bug's been filed about it yet.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, bent found it while looking at a patch that moved this code around.  We came up with a plan for catching these sorts of errors at the work week today.  More to come.

Also we really need to run b2g with leak checking turned on.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/464a1e7fb0d9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f93e5ee842ed

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Not sure if this is considered "stability" enough to be considered for v1.2 uplift still. You'll want to run it past RelMan if you think this should be uplifted there still.