965506 - (Synth APK) - Invalid XML - APK Factory fails on Snakes & Ladders/Eight Ball Champion/Metro 3 /Compass

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Aaron Train [:aaronmt]]

https://marketplace.firefox.com/app/05e0b2c0-7d5f-43c4-8ae9-22bc07ebbb78/manifest.webapp
https://marketplace.firefox.com/app/691472ff-d766-4bae-92cd-b9bd60e6b5d2/manifest.webapp
https://marketplace.firefox.com/app/c6dc6079-f492-43c8-bb5f-2c2941103686/manifest.webapp
https://marketplace.firefox.com/app/95d3d75c-e822-4da8-b1df-b95ae85fc8c8/manifest.webapp

{"name": "Snakes & Ladders", "icons": {"48": "/Icon-48.png", "16": "/Icon-16.png", "32": "/Icon-32.png", "30": "/Icon-30.png", "60": "/Icon-60.png", "64": "/Icon-64.png", "128": "/Icon-128.png", "90": "/Icon-90.png", "250": "/Icon-250.png"}, "version": "1.0.2", "package_path": "https://marketplace.firefox.com/downloads/file/238462/snakes-ladders-1.0.2.zip", "size": 3573568, "release_notes": "", "developer": {"url": "https://www.techtreeit.com", "name": "TechTreeIT"}}

{"name": "Eight Ball Champion", "icons": {"128": "/img/icon-128.png", "48": "/img/icon-48.png", "16": "/img/icon-16.png"}, "version": "1.0", "package_path": "https://marketplace.firefox.com/downloads/file/231644/eight-ball-champion-1.0.zip", "size": 5161068, "release_notes": null, "developer": {"url": "http://www.tweensoft.com", "name": "TweenSoft Inc."}}

{"name": "Metro-3", "icons": {"60": "/assets/icon60.png", "128": "/assets/icon.png"}, "version": "1", "package_path": "https://marketplace.firefox.com/downloads/file/228759/metro-3-1.zip", "size": 184385, "release_notes": null, "developer": {"url": "http://louisstowasser.com", "name": "Louis Stowasser"}}

{"name": "Compass", "icons": {"128": "/images/compass.png"}, "version": "1.0.2", "package_path": "https://marketplace.firefox.com/downloads/file/238451/compass-3-1.0.2.zip", "size": 975684, "release_notes": "", "developer": {"url": "https://techtreeit.com", "name": "Techtree"}}

curl: (52) Empty reply from server

Comment 1

[Austin King [:ozten]]

Eight Ball Champion, Metro-3 and Compass fixed with bug#965845.

Snakes & Ladders - investigating
BUILD FAILED
/data/android-sdk-linux/tools/ant/build.xml:653: The following error occurred while executing this line:
/data/android-sdk-linux/tools/ant/build.xml:698: null returned: 1

Total time: 4 seconds

    at ChildProcess.exithandler (child_process.js:637:15)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at maybeClose (child_process.js:735:16)
    at Process.ChildProcess._handle.onexit (child_process.js:802:5)

Comment 2

[Austin King [:ozten]]

The issue is with templatizing strings.xml.

For the game 'Snakes & Ladders' we generate this xml:

<resources>

    <string name="app_name">"Snakes & Ladders"</string>
    <string name="app_description">"Snakes  And Ladders  is a popular dice game playe\
d widely throughout the world by all age group players. Excellent time pass game wher\
e players can see how progress/ downfall happens based on the ladder/ snake positions\
 in the game, that is how it is for a soul to reach ultimate liberation in life.Play \
the game either in single or double player mode. Enjoy this game with nice looking gr\
aphics and superior game play."</string>

</resources>

Comment 3

[Austin King [:ozten]]

jhugman or myk:

What would be best?
* Use CDATA in templates
* Use XML escaping (if so, any thoughts on a NodeJS library here?)
* ???

Comment 4

[Austin King [:ozten]]

Not sure this is the best way to solve this...
https://github.com/mozilla/apk-factory-service/pull/37

Comment 5

[Myk Melez [:myk] [@mykmelez]]

I think the XML escaping in the pull request is a good solution (albeit incomplete, given locale-based strings, as you mentioned in the pull request).  It feels more conventional and easier to understand than CDATA sections.

Comment 6

[Austin King [:ozten]]

Thanks myk!

I guess we need to escape the description field under each locale.
https://developer.mozilla.org/en-US/Apps/Developing/Manifest#locales

Comment 7

[Austin King [:ozten]]

Added escaping of description field under each locale.

Untested, I could use some OWA manifest urls that actually use multiple locales.

Pushed to dapk.net