Closed
Bug 965519
Opened 11 years ago
Closed 11 years ago
add python packages to mozharness
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
93.34 KB,
patch
|
jgriffin
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
mozprocess (also mozinfo mozfile)
requests
boto
Normally we would create a virtualenv to run the mozharness script in, but that would require a bootstrapping script that would also need to be configurable + error detecting. That may be the route we go later, but for now I want to investigate checking the above packages into mozharness for more robust downloads + clones.
Assignee | ||
Comment 1•11 years ago
|
||
Passes my preliminary testing. I'd want a full test run on Ash or Cypress before merging to production.
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8367634 [details] [diff] [review]
mozprocess-in-mozharness
I basically cloned mozbase from github, and copied over the mozinfo mozfile mozprocess dirs from the mozprocess-0.15 tag.
I was able to verify that a subprocess run in the venv imported the venv mozprocess, not mozharness/mozprocess.
Attachment #8367634 -
Flags: review?(jgriffin)
Assignee | ||
Comment 3•11 years ago
|
||
Not sure if this is sufficient?
I think I was mistaken about dependencies, but I'm not sure if you need boto/bin or any other packages.
Attachment #8367651 -
Flags: review?(catlee)
Comment 4•11 years ago
|
||
Comment on attachment 8367634 [details] [diff] [review]
mozprocess-in-mozharness
Review of attachment 8367634 [details] [diff] [review]:
-----------------------------------------------------------------
Cool, lgtm
Attachment #8367634 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8367634 [details] [diff] [review]
mozprocess-in-mozharness
https://hg.mozilla.org/build/mozharness/rev/e4a7a35849ee
Attachment #8367634 -
Flags: checked-in+
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8367651 [details] [diff] [review]
add boto 2.23.0 and requests 2.2.1
[12:25] <catlee> aki: I don't think our machines have the python ssl libs install for requests to work properly
[12:25] <aki> boo
[12:25] <aki> run_command("wget...") ?
[12:25] <catlee> yeah
[12:25] <catlee> heheh
[12:26] <catlee> it also makes me feel dirty to ship boto+requests in mozharness
[12:26] <aki> yeah. mozprocess is at least mozilla built
Attachment #8367651 -
Attachment is obsolete: true
Attachment #8367651 -
Flags: review?(catlee)
Assignee | ||
Comment 7•11 years ago
|
||
mozprocess is in production, and boto/requests have been wontfixed, so resolving.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Component: General Automation → Mozharness
You need to log in
before you can comment on or make changes to this bug.
Description
•