965541 - Fix panel UI sync widget and panel UI separator styling

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

The sync widget introduced by bug 957460 broke toolbarbutton separators and looks a little unfortunate on Windows. Let's fix that.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-965541-Fix-sync-widget-styling-located-in-the-pa.patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-965541-Fix-sync-widget-styling-located-in-the-pa.patch, v2

Great, found a much better solution for the cropping part. Adding Mike as a reviewer, maybe he has some free cycles to get to this earlier while Gijs is asleep :)

Comment 3

[:Gijs (he/him)]

Comment on attachment 8367744 [details] [diff] [review]
0001-Bug-965541-Fix-sync-widget-styling-located-in-the-pa.patch, v2

Review of attachment 8367744 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +297,5 @@
>  
>  #PanelUI-fxa-status > .toolbarbutton-text,
>  #PanelUI-customize > .toolbarbutton-text {
> +  margin: 0;
> +  padding: 0 6px;

Is this really also neaded for the customize button, or just for the FXA-status button? In the latter case, it can go into the rule you inserted above.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Gijs Kruitbosch from comment #3)
> >  #PanelUI-fxa-status > .toolbarbutton-text,
> >  #PanelUI-customize > .toolbarbutton-text {
> > +  margin: 0;
> > +  padding: 0 6px;
> 
> Is this really also neaded for the customize button, or just for the
> FXA-status button? In the latter case, it can go into the rule you inserted
> above.

The customize button was a little off on Linux as well because toolbarbutton.css sets "margin:0 !important". I though it would be better to normalize this on all platforms and then just use a padding to have some space between the icon and the label.

Comment 5

[:Gijs (he/him)]

At least on OS X this also fixes bug 962855.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/8c00a78919c3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c00a78919c3

Comment 8

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora