Closed
Bug 965541
Opened 11 years ago
Closed 11 years ago
Fix panel UI sync widget and panel UI separator styling
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 29
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P3][qa!])
Attachments
(1 file, 1 obsolete file)
|
2.11 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
The sync widget introduced by bug 957460 broke toolbarbutton separators and looks a little unfortunate on Windows. Let's fix that.
|
||
Updated•11 years ago
|
Whiteboard: [qa+]
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8367678 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 2•11 years ago
|
||
Great, found a much better solution for the cropping part. Adding Mike as a reviewer, maybe he has some free cycles to get to this earlier while Gijs is asleep :)
Attachment #8367678 -
Attachment is obsolete: true
Attachment #8367678 -
Flags: review?(gijskruitbosch+bugs)
Attachment #8367744 -
Flags: review?(mconley)
Attachment #8367744 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8367744 [details] [diff] [review]
0001-Bug-965541-Fix-sync-widget-styling-located-in-the-pa.patch, v2
Review of attachment 8367744 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +297,5 @@
>
> #PanelUI-fxa-status > .toolbarbutton-text,
> #PanelUI-customize > .toolbarbutton-text {
> + margin: 0;
> + padding: 0 6px;
Is this really also neaded for the customize button, or just for the FXA-status button? In the latter case, it can go into the rule you inserted above.
Attachment #8367744 -
Flags: review?(mconley)
Attachment #8367744 -
Flags: review?(gijskruitbosch+bugs)
Attachment #8367744 -
Flags: review+
|
|
||
Updated•11 years ago
|
Blocks: australis-cust
Summary: Fix sync widget styling located in the panel UI → Fix panel UI sync widget and panel UI separator styling
Whiteboard: [qa+] → [Australis:P3][qa+]
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3)
> > #PanelUI-fxa-status > .toolbarbutton-text,
> > #PanelUI-customize > .toolbarbutton-text {
> > + margin: 0;
> > + padding: 0 6px;
>
> Is this really also neaded for the customize button, or just for the
> FXA-status button? In the latter case, it can go into the rule you inserted
> above.
The customize button was a little off on Linux as well because toolbarbutton.css sets "margin:0 !important". I though it would be better to normalize this on all platforms and then just use a padding to have some space between the icon and the label.
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
||
Comment 8•11 years ago
|
||
Verified with latest builds of Nightly and Aurora
Status: RESOLVED → VERIFIED
Whiteboard: [Australis:P3][qa+] → [Australis:P3][qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•