Calls to reboot method should not specify port, use keyword arguments

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Using positional elements is more brittle than keyword ones, since it can break if the order changes. Also, we don't need/want to specify a port anymore: now that bug 964516 has landed (and mozdevice 0.32 has been released), we'll automatically select and use a unique one, with no chance of races, etc.
Created attachment 8367618 [details] [diff] [review]
Call devicemanager's reboot with keyword arguments, don't specify port;r=bc
Attachment #8367618 - Flags: review?(bclary)
Created attachment 8367625 [details] [diff] [review]
Patch against up to date version

Previous patch was against a really obsolete version of autophone. Oops.
Attachment #8367618 - Attachment is obsolete: true
Attachment #8367618 - Flags: review?(bclary)
Attachment #8367625 - Flags: review?(bclary)

Updated

5 years ago
Attachment #8367625 - Flags: review?(bclary) → review+
https://github.com/mozilla/autophone/commit/69948a83c98dbd9c41dd81bdb7cc16812d87c65a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.