Closed
Bug 965557
Opened 10 years ago
Closed 10 years ago
Calls to reboot method should not specify port, use keyword arguments
Categories
(Testing Graveyard :: Autophone, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file, 1 obsolete file)
|
1.35 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
Using positional elements is more brittle than keyword ones, since it can break if the order changes. Also, we don't need/want to specify a port anymore: now that bug 964516 has landed (and mozdevice 0.32 has been released), we'll automatically select and use a unique one, with no chance of races, etc.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8367618 -
Flags: review?(bclary)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Previous patch was against a really obsolete version of autophone. Oops.
Attachment #8367618 -
Attachment is obsolete: true
Attachment #8367618 -
Flags: review?(bclary)
Attachment #8367625 -
Flags: review?(bclary)
|
||
Updated•10 years ago
|
Attachment #8367625 -
Flags: review?(bclary) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://github.com/mozilla/autophone/commit/69948a83c98dbd9c41dd81bdb7cc16812d87c65a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•