965588 - Remove 'update_files' logic from B2G unittest mozharness scripts

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jonathan Griffin (:jgriffin)]

We used to run B2G unittests by downloading a static copy of the emulator and updating the copy of gecko running in it.  We don't do this any longer, and we should remove the logic that handles this from the mozharness scripts.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Remove update_files logic from B2G scripts,

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8368050 [details] [diff] [review]
Remove update_files logic from B2G scripts,

Review of attachment 8368050 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! I was going to say why not remove EmulatorMixin too, but looks like Android is still using it.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8368050 [details] [diff] [review]
Remove update_files logic from B2G scripts,

https://hg.mozilla.org/build/mozharness/rev/198f4b5bc686

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: Remove --no-update from B2G script invocation,

The next part of this job is to remove --no-update from everywhere we call it in buildbot-configs.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8368692 [details] [diff] [review]
Remove --no-update from B2G script invocation,

Ahh, there's so many!

Comment 6

[Andrew Halberstadt [:ahal]]

I backed out the first patch due to emulator bustage (bug 966883:
https://tbpl.mozilla.org/php/getParsedLog.php?id=33917918&tree=Cedar

https://hg.mozilla.org/build/mozharness/rev/1498c10c0430

Comment 7

[Jonathan Griffin (:jgriffin)]

Attachment: Remove update_files logic from B2G scripts,

Fixed the error and am testing on ash.

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8369748 [details] [diff] [review]
Remove update_files logic from B2G scripts,

Review of attachment 8369748 [details] [diff] [review]:
-----------------------------------------------------------------

Carry r+ forward.

Comment 9

[Jonathan Griffin (:jgriffin)]

(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Created attachment 8369748 [details] [diff] [review]
> Remove update_files logic from B2G scripts,
> 
> Fixed the error and am testing on ash.

This worked on ash.

Comment 10

[Jordan Lund (:jlund)]

a mozharness patch has been merged into production :)

Comment 11

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8369748 [details] [diff] [review]
Remove update_files logic from B2G scripts,

https://hg.mozilla.org/build/mozharness/rev/bd5b7369f34e

Comment 12

[John Hopkins (:jhopkins)]

in production

Comment 13

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8368692 [details] [diff] [review]
Remove --no-update from B2G script invocation,

Finally landed the buildbot-configs part of this:

https://hg.mozilla.org/build/buildbot-configs/rev/e3c40121b7a7

Comment 14

[John Hopkins (:jhopkins)]

In production.

Comment 15

[Jonathan Griffin (:jgriffin)]

Attachment: Remove --no-update from B2G mozharness scripts,

Ok, this is the last piece of this.

Comment 16

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8382367 [details] [diff] [review]
Remove --no-update from B2G mozharness scripts,

https://hg.mozilla.org/build/mozharness/rev/4173b756ffde

Comment 17

[Jonathan Griffin (:jgriffin)]

in production