Closed Bug 965588 Opened 8 years ago Closed 8 years ago

Remove 'update_files' logic from B2G unittest mozharness scripts

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(3 files, 1 obsolete file)

We used to run B2G unittests by downloading a static copy of the emulator and updating the copy of gecko running in it.  We don't do this any longer, and we should remove the logic that handles this from the mozharness scripts.
Attachment #8368050 - Flags: review?(ahalberstadt)
Comment on attachment 8368050 [details] [diff] [review]
Remove update_files logic from B2G scripts,

Review of attachment 8368050 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! I was going to say why not remove EmulatorMixin too, but looks like Android is still using it.
Attachment #8368050 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8368050 [details] [diff] [review]
Remove update_files logic from B2G scripts,

https://hg.mozilla.org/build/mozharness/rev/198f4b5bc686
Attachment #8368050 - Flags: checked-in+
The next part of this job is to remove --no-update from everywhere we call it in buildbot-configs.
Attachment #8368692 - Flags: review?(ahalberstadt)
Attachment #8368050 - Attachment is obsolete: true
Attachment #8368050 - Attachment is obsolete: false
Comment on attachment 8368692 [details] [diff] [review]
Remove --no-update from B2G script invocation,

Ahh, there's so many!
Attachment #8368692 - Flags: review?(ahalberstadt) → review+
Fixed the error and am testing on ash.
Attachment #8368050 - Attachment is obsolete: true
Comment on attachment 8369748 [details] [diff] [review]
Remove update_files logic from B2G scripts,

Review of attachment 8369748 [details] [diff] [review]:
-----------------------------------------------------------------

Carry r+ forward.
Attachment #8369748 - Flags: review+
(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Created attachment 8369748 [details] [diff] [review]
> Remove update_files logic from B2G scripts,
> 
> Fixed the error and am testing on ash.

This worked on ash.
a mozharness patch has been merged into production :)
Comment on attachment 8369748 [details] [diff] [review]
Remove update_files logic from B2G scripts,

https://hg.mozilla.org/build/mozharness/rev/bd5b7369f34e
Attachment #8369748 - Flags: checked-in+
in production
Comment on attachment 8368692 [details] [diff] [review]
Remove --no-update from B2G script invocation,

Finally landed the buildbot-configs part of this:

https://hg.mozilla.org/build/buildbot-configs/rev/e3c40121b7a7
Attachment #8368692 - Flags: checked-in+
In production.
Ok, this is the last piece of this.
Attachment #8382367 - Flags: review?(ahalberstadt)
Attachment #8382367 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8382367 [details] [diff] [review]
Remove --no-update from B2G mozharness scripts,

https://hg.mozilla.org/build/mozharness/rev/4173b756ffde
Attachment #8382367 - Flags: checked-in+
in production
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 977702
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.