Closed Bug 965602 Opened 10 years ago Closed 10 years ago

Dragging icons into padding sometimes makes a bunch of other icons disappear

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Version:
29 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 29

People

(Reporter: alice0775, Assigned: Gijs)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Australis:P2])

Attachments

(3 files)

screenshot
108.95 KB, image/png
Details
20140130_1009_00.swf
563.52 KB, application/x-shockwave-flash
Details
dragexit should always reset dragoveritem in Australis' customize mode,
1.60 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review
Attached image screenshot — 
See screenshot, some icons such as Find, Options and Developer are missing.
Summary: Missing icon while customize → Missing icon while customize mode
Blocks: australis-cust
Whiteboard: [Australis:P1]
Steps To Reproduce:
1. Enter Customize mode
2. Drag a icon e.g. "New Window" icon
   And drop it on Blue border area quickly


Actual Results:
Some icons are gone

Regression window:
Good(No Australis):
http://hg.mozilla.org/mozilla-central/rev/beddd6d4bcdf
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118030203
Bad:
http://hg.mozilla.org/mozilla-central/rev/f2adb62d07eb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118094134
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=beddd6d4bcdf&tochange=f2adb62d07eb

The problem is reproducble since UX marge day....
Keywords: regressionwindow-wanted
Attached file 20140130_1009_00.swf — 
Screen capture
I can reproduce this on OS X...
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: Missing icon while customize mode → Dragging icons into padding sometimes makes a bunch of other icons disappear
(normally this case is caught by dragexit, but if you move the mouse really quickly it might not be, and so stuff ends up being perpetually transformed - this patch fixes it by ensuring dragend always resets the dragoveritem if necessary)
Also, although this is serious, as soon as you exit customize mode, stuff is fine again, so I don't think it's P1 after all. :-)
Whiteboard: [Australis:P1] → [Australis:P2]
Attachment #8367902 - Flags: review?(mdeboer) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/d5823c08b120
Whiteboard: [Australis:P2] → [Australis:P2][fixed-in-fx-team]
Blocks: australis-merge
No longer blocks: 646359
https://hg.mozilla.org/mozilla-central/rev/d5823c08b120
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][fixed-in-fx-team] → [Australis:P2]
Target Milestone: --- → Firefox 29
Verified as fixed in Nightly (build ID: 20140226030202) and Aurora (build ID: 20140227004002).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.