96562 - JS Engine version-dependent keywords not maintained properly.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Conrad Carlen (not reading bugmail)]

This problem shows itself when going to http://home.netscape.com while using
turbo mode. This page sets the JS version to something lower than is needed to
deal with chrome, causing chrome JS to fail.

Comment 1

[Brendan Eich [:brendan]]

The problem is that JSContext.scannerVersion should be in the JSRuntime.  What a
botch.  Easily fixed, patch coming up.

/be

Comment 2

[Brendan Eich [:brendan]]

Argh, it's harder than that.  Multi-threading screws my simple plan.  There is
in fact a problem with keyword reserved-ness being stored in the atom table,
shared among all JSContexts.  More in a bit, still trying for 0.9.4 to unblock
conrad's bug.

/be

Comment 3

[Bradley Baetz (:bbaetz)]

Could this be causing bug 74539 as well?

Comment 4

[jag (Peter Annema)]

*blink*

*blink*

Comment 5

[jag (Peter Annema)]

Yeah, I think they're one and the same bug (at least the initial comment, dunno
about what follow-up stuff was commented in there).

Comment 6

[Brendan Eich [:brendan]]

Attachment: proposed fix (diff -u, for applying)

Comment 7

[Brendan Eich [:brendan]]

Attachment: diff -wu version of patch, for reviewing

Comment 8

[Brendan Eich [:brendan]]

Conrad, apply the first attachment in your mozilla/js/src directory and remake
there.  Let me know if this doesn't cure the symptom.  With this change, I pass
the JS testsuite and Mozilla runs fine.

Looking for r= and sr=.

/be

Comment 9

[Brendan Eich [:brendan]]

Better summary.

/be

Comment 10

[Conrad Carlen (not reading bugmail)]

Alright - the patch works!

Comment 11

[Mike Shaver (:shaver emeritus)]

sr=shaver

Comment 12

[rogerl (gone)]

r=rogerl

(except after I patched jsscan.c, I saw 'indenting issues' at line #782).

Comment 13

[John Bandhauer]

It looks OK to me (though you already have your cookies :)

r=jband

Comment 14

[Brendan Eich [:brendan]]

rogerl: did you apply the diff -u, or the diff -wu?  The former is for applying
via patch, the latter for reviewing.

Thanks all, going for approval.

/be

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron (on behalf of drivers)

Comment 16

[Brendan Eich [:brendan]]

Fix checked in.

/be

Comment 17

[Paul Chen]

*** Bug 74539 has been marked as a duplicate of this bug. ***