965623 - Media Tools framework for Talos Media Perf tests

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P4)

Description

[Suhas]

Framework for carrying out processing of media to be used for Talos Media Peformance analysis. Idea is to start something small and add more functionalities as the scope is expanded.

Comment 1

[Suhas]

Attachment: Initial Media Tools Framework for Talos

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8367736 [details]
Initial Media Tools Framework for Talos

Licenses are needed on gyp files - if code is copied, then from there; if new, then MPL2 please.

If this is modified from webrtc.org code, those licenses need to be kept, and the parts of the code appear to be from the webrtc unit tests.

spaces around ':' after function prototype (i.e. foo::bar() : init(1),...)

You may want to increase MAX_SAMPLES - stereo, 48KHz, 60ms is what I think the max is in webrtc.  Doesn't cost us much to do that.

Rework/change the max_delay calculation - that's cut-and-pasted from a test for a resampler with a known max delay.  You'll want to use something longer (much), but perhaps cut off the search if we're way above the minimum as we move away from it - that can be an improvement for later, if ever.  Make it an input parameter so it can be tuned in the scripts.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Yeah I found this bug from related bugs around talos and snr, and linked it to keep track of it. Unclear what work it tracks and if anything remains. Perhaps it's old and can be closed? If not, a re-outline of remaining tasks would be great!

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Joel - Is this bug/code still relevant, or is it overtaken by events?  If this code was used to check stuff in, we should review this code and get it into the tree somewhere; if this is no longer needed for anything we could close the bug.

Thanks!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I believe this is the SNR tools we are using as a replacement for PESQ?  If that is true, I want to make sure we have a way to reference that toolchain and can rebuilt it if needed.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Thanks Joel; Jan-Ivar - let's get this cleaned up and in source control (somewhere).  Joel - suggestions as to where tools like this should live?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

I am fine with github- I would like to know it is complete- I can put a readme.txt file in the talos media subdir that references it.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Seems to precede the new planning model. Not presently working on this for goals. Requesting reassignment.

Comment 9

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.