Closed Bug 965683 Opened 10 years ago Closed 10 years ago

Android spinner that replaces button is too big

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa+])

Attachments

(1 file)

The button "grows" a few pixels when the spinner replaces it.  Presumably, we're wrapping height to all content, rather than just to the button's content (and forcing the spinner to shrink).
Attached file github PR
Would love to uniformize this, but the text of the button is different in the three different activities :(
Attachment #8368843 - Flags: review?(rnewman)
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8368843 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/2a311162943f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa+][fixed in services] → [qa+]
Target Milestone: --- → Firefox 29
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: