965715 - [regression] JavaScript-global-constructor object has no interface

Status: RESOLVED WONTFIX

(Core :: XPConnect, defect)

Description

[Jan Gerber]

Objects created via JavaScript-global-constructor by an add-on no longer
have the interface defined via QueryInterface: XPCOMUtils.generateQI(..).

This started happening in recent Nightlies.
Last stable release (26) still exposes the interface as expected.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Jan, could you post an example testcase (small addon that easily shows the problem)?

Or alternately, would you be willing to find the first nightly that changed the behavior?

Comment 2

[Jan Gerber]

Attachment: JsGlobal.xpi

Source of extension can also be found at:

 http://r-w-x.org/?p=jsglobal.git;a=summary

example use that fails in nightly:

g = new JsGlobal();
console.log('g.foo', g.foo);
console.log('g.bar()', g.bar());

Comment 3

[Boris Zbarsky [:bzbarsky]]

Jan, thanks!

It looks like the issue you're having is that nsISecurityCheckedComponent has been removed.  See bug 794943.  So Ci.nsISecurityCheckedComponent in your component is undefined and things go south.

I tried just removing the nsISecurityCheckedComponent bits and everything _seems_ to work after that...  Bobby, is that expected?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oh, I see.  There's an nsIClassInfo with DOM_OBJECT set.  So the nsISecurityCheckedComponent bits are just superfluous.

Comment 5

[Boris Zbarsky [:bzbarsky]]

We're not going to reintroduce nsISecurityCheckedComponent, so wontfix, I guess, but fixing the addon in this case should be pretty simple.

Comment 6

[Bobby Holley (:bholley)]

(In reply to Boris Zbarsky [:bz] from comment #5)
> fixing the addon in this case should be pretty simple.

Note that in this case, fixing the addon should just involve removing the references to nsISecurityCheckedComponent, since the addon also implements nsIClassInfo, and flags itself as DOM_OBJECT.

Comment 7

[Jan Gerber]

Thanks, removing nsISecurityCheckedComponent and related code indeed fixes Firefogg.
I remember this was needed at some point to pass File objects,
but always great if removing code can fix things.