Closed
Bug 965798
Opened 10 years ago
Closed 10 years ago
remove PRODUCT_MAP from feedback/config.py
Categories
(Input Graveyard :: Code Quality, defect, P1)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=dev c=codequality p=1 s=input.2014q1)
After the product table is implemented, we can probably remove the PRODUCT_MAP from feedback/config.py and recode the product validation bits.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Actually, we should have this cover whatever product validation we're doing in the Input API, too.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → willkg
Whiteboard: u=dev c=codequality p= s=input.2014q1 → u=dev c=codequality p=1 s=input.2014q1
|
|
Assignee | |
Comment 2•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/207
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•10 years ago
|
||
Not sure why I made this a P3. It should be a P1 because it's essentially the whole point of the product table.
Priority: P3 → P1
|
|
Assignee | |
Comment 4•10 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/e633e6d https://github.com/mozilla/fjord/commit/b141cce Will push on Monday because release week.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•