965832 - Nav bar selection monocles don't appear when tapping text

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Jim Mathies [:jimm]]

STR:

1) type some text in the nav bar with the keyboard
2) tap the text

expected: skb is displayed, text is selected, and selection monocles come up

result: no selection monocles

We have a test for this which isn't failing although we won't get the soft keyboard in automated tests.

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

They appear, they just remain hidden. I'll see if I can add a test for this too.

Comment 2

[Jim Mathies [:jimm]]

oops, ignore all that debug gunk.

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8368009 [details] [diff] [review]
fix

This can be cleaned up even further.

Comment 5

[Jim Mathies [:jimm]]

Attachment: fix v.1

Comment 6

[Jim Mathies [:jimm]]

Attachment: tests

Comment 7

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/?tree=Try&showall=0&rev=39817e00e15d

Comment 8

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/cd164c7bddb0
https://hg.mozilla.org/integration/fx-team/rev/40ad681596fa

Comment 9

[Marco Mucci [:MarcoM]]

Hey Jim, can you provide a point value.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd164c7bddb0
https://hg.mozilla.org/mozilla-central/rev/1e679dc9033c

Comment 11

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified as fixed with a Surface Pro 2 device on latest Aurora (build ID: 20140206004003).
The selection monocles are now properly displayed.