Closed Bug 965867 Opened 7 years ago Closed 7 years ago

Update final URLs for Android Firefox Accounts landing

Categories

(Firefox for Android :: Android Sync, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 29
Tracking Status
firefox29 --- verified

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa+])

Attachments

(1 file)

57 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review
We need to rev all of our URLs for final sign off: Old Firefox, Terms of Service, Privacy Notice, Forgot password?, etc.

Per discussion in Bug 965376, we're going to take these URLs away from localizers, so we can rev them freely.
Whiteboard: [qa+]
Per 959849, "Using an older version of Sync?" links in Android should point at https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/old-sync
New code generates links that will look like: 

I FxAccounts(372)             fennec_nalexander :: FxAccountGetStartedActivity :: $$FxA PII$$: Old Firefox url is: https://support.mozilla.org/1/mobile/24.0a1/Android/en-US/old-sync
Attached file github PR
This makes the strings look like:

<!-- Firefox Account links. -->
<!-- https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/old-sync -->
<string name="fxaccount_link_old_firefox">https://support.mozilla.org/1/mobile/&formatS1;/&formatS2;/&formatS3;/old-sync</string>
<string name="fxaccount_link_create_not_allowed">http://www.consumer.ftc.gov/articles/0031-protecting-your-childs-privacy-online</string>
<string name="fxaccount_link_tos">https://accounts.firefox.com/legal/terms</string>
<string name="fxaccount_link_pn">https://accounts.firefox.com/legal/privacy</string>
<string name="fxaccount_link_forgot_password">https://accounts.firefox.com/reset_password</string>
Attachment #8368118 - Flags: review?(rnewman)
Attachment #8368118 - Flags: feedback?(rlord)
Attachment #8368118 - Flags: feedback?(rfeeley)
s/strings/URLs/
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Note to lander: this needs formatS3 added to mobile/android/base/strings.xml.in.
Comment on attachment 8368118 [details] [review]
github PR

Nits on GH.
Attachment #8368118 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/85db73060d6b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [qa+][fixed in services] → [qa+]
Target Milestone: --- → Firefox 29
The corrects links are implemented in the nightly build! Setting this as Verified Fixed.
PS: Some of the links are blanks - not having content

Device: Galaxy Nexus 
OS: Android 4.3
Build: 01/31
Status: RESOLVED → VERIFIED
Comment on attachment 8368118 [details] [review]
github PR

Done, landed, shipped, so clearing f? requests.
Attachment #8368118 - Flags: feedback?(rlord)
Attachment #8368118 - Flags: feedback?(rfeeley)
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.