966023 - [B2G][Clock][Timer] Sounds previews continue to play from the timer "Sound list" when locking the device

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Salem Elkabule]

Attachment: Timer sound log.txt

Description:
When selecting an alarm sound from the timer "Sound list" and locking the device, the sound preview continues to play when the screen is locked. When the user taps on the lock screen the sound will terminate

Repro Steps:
1) Updated Buri to 20140127004002 
2) Launch the Clock app and navigate to timer
3) Select a sound from the "Sound list"
4) While the sound is playing lock the screen

Actual:
The sound continues to play when the screen is locked

Expected:
The sound playing from the timer stops when the screen is locked

Environmental Variables
Device: Buri 1.3 MOZ RIL
Build ID: 20140127004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/c40099a42c1f
Gaia: 25a45a836a4a21a30f63fa7b544b42e8b781180a
Platform Version: 28.0a2
Firmware Version: v1.2-device.cfg


Repro frequency: 100%
See attached: Video clip (http://www.youtube.com/watch?v=LvLmJDlrKXQ), logcat

Comment 1

[Salem Elkabule]

The issue does not reproduce on buri V1.2 

Environmental Variables:
Device: buri V1.2 MOZ RIL
Build ID: 20140128004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/d10e1f965d0c
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
Firmware Version: v1.2-device.cfg

The user is unable to preview the sound list on the buri V1.2

Comment 2

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15920/files

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8369568 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15920/files

[p.s: Mike, do you still want to do reviews, or should I defer those to others?]

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8369568 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15920/files

I updated the PR to reflect your github comment.

Comment 5

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8369568 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15920/files

Looks good to me!

Comment 6

[Mike Pennisi [:jugglinmike]]

(In reply to Marcus Cavanaugh [:mcav] <[e-mail]> from comment #3)
> [p.s: Mike, do you still want to do reviews, or should I defer those to
> others?]

I decided to stay on as a peer of this module exactly so that I could help out with reviews, so keep them coming! My only caveat (and as you've probably noticed): I won't be conducting reviews during normal business hours, so if it needs immediate attention, you might want to contact a different reviewer.

Comment 7

[Marcus Cavanaugh [:mcav]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/9a69f4145304cbbd6937739a823a53558c9907d7

Comment 8

[Edward Chen[:edchen]]

[Verified info]
Gaia      bf497b7adfaa4c087d492acf7f143a61b5ec08e9
Gecko     https://hg.mozilla.org/mozilla-central/rev/339f0d450d46
BuildID   20140217160203
Version   30.0a1

[Testing result]
PASS
The bug has been fixed, I mark it to "VERIFIED'.