966121 - xperf whitelist not including contents of target's dependentlibs.list

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We should always, as part of the xperf test, be reading in the dependentlibs.list of the target installation and automatically whitelisting its contents.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Hmm... the code is in there to be doing this, but apparently it isn't. More investigation is required.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I am debugging this

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I got a failure and we are reading dependentlibs:
05:48:33     INFO -  JMAHER: approot: C:\slave\test\build\application\firefox
05:48:33     INFO -  JMAHER: looking for dependentlibs.list: C:\slave\test\build\application\firefox\dependentlibs.list
05:48:33     INFO -  JMAHER: adding lib to wl_temp: MSVCR100.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: MSVCP100.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: mozglue.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: nss3.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: icudt50.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: icuuc50.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: icuin50.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: mozjs.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: mozalloc.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: gkmedias.dll
05:48:33     INFO -  JMAHER: adding lib to wl_temp: xul.dll
05:48:33     INFO -  TEST-UNEXPECTED-FAIL : xperf: File 'c:\program files\nvidia corporation\3d vision\nvstereoapii.dll' was accessed and we were not expecting it.  DiskReadCount: 4, DiskWriteCount: 0, DiskReadBytes: 33792, DiskWriteBytes: 0

is nvstereoapii.dll supposed to be in dependentlibs.list?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

my try run has failing and passing xperf tests while reading the same set of dll's from dependentlibs.list:
https://tbpl.mozilla.org/?tree=Try&rev=cec60eacd9db

could it be we have a different version of a driver on some of our machines?

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Joel Maher (:jmaher) from comment #3)

> is nvstereoapii.dll supposed to be in dependentlibs.list?

No, it isn't.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: needed to add the files in the right way (1.0)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/f91e95196e9e

:aklotz- should we remove the files which are listed in dependentlibs.list from the whitelist.json?

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

Makes sense to me.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: removed files from whitelist that exist in dependentlibs.list (1.0)

this should finish out our xperf stuff.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: removed files from whitelist that exist in dependentlibs.list (1.1)

accidentally had some extra files in the patch, right patch this time.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/b5074bebe877

As this is not critical, I will wait until we have a more pressing need to deploy talos to pick these changes up.