Closed Bug 966132 Opened 6 years ago Closed 6 years ago
[b2g][pdfjs] gaia master fails to open any pdf with Type
So this isn't going to be a Gaia regression - we haven't changed version of pdf.js since Oct 21st. The line of code failing is: globalScope.console = workerConsole; My guess is that this is a DOM regression, so let's start there. Will work on getting a regression window to help diagnose this though.
Component: Gaia → DOM
Product: Firefox OS → Core
I'm going to put money on bug 620935 being the cause, although I suspect the fix is in gaia.
Jason, thank you for looking up the relevant code bit! On main thread, window.console is a replaceable property. I would say we should do that in workers as well. Then the code in question will just work (and override the built-in console, but that's the whole point of making it replaceable).
Assignee: nobody → amarchesini
Comment on attachment 8368535 [details] [diff] [review] worker.patch >+ if (!event.data.status || event.data.last) Why do you need that first condition? If it tests true, won't we double-finish the test? I think we should finish() here only if event.data.last. r=me with that.
Attachment #8368535 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.