Closed Bug 966150 Opened 6 years ago Closed 6 years ago

Preferences Sync header does not match UX

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: rfeeley, Assigned: Gavin)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8368393 - Flags: review?(ttaubert)
Comment on attachment 8368393 [details] [diff] [review]
patch

Review of attachment 8368393 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/sync.xul
@@ +252,5 @@
>              </deck>
>            </groupbox>
>  
>            <groupbox id="syncOptions">
> +            <caption label="&syncService.label;"/>

What's the reason we just don't use &syncBrand.shortName.label?
That's "Firefox Sync", we want it to just be "Sync".
Attached patch patchSplinter Review
Attachment #8368393 - Attachment is obsolete: true
Attachment #8368393 - Flags: review?(ttaubert)
Attachment #8368394 - Flags: review?(ttaubert)
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #3)
> That's "Firefox Sync", we want it to just be "Sync".

I was wrong!
No longer blocks: 964920
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 8368394 [details] [diff] [review]
patch

Review of attachment 8368394 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.
Attachment #8368394 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/260266bdf0ca
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.