966150 - Preferences Sync header does not match UX

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Currently Firefox Sync + Sync My is shown
https://www.dropbox.com/s/y0525364fzlvs2w/sync-prefs.png

As designed is simply Sync:
https://www.dropbox.com/s/vhq6ilehd29dpvx/Desktop%20-%20Preferences%20-%20Sync%20-%20Signed%20In.pdf

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8368393 [details] [diff] [review]
patch

Review of attachment 8368393 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/sync.xul
@@ +252,5 @@
>              </deck>
>            </groupbox>
>  
>            <groupbox id="syncOptions">
> +            <caption label="&syncService.label;"/>

What's the reason we just don't use &syncBrand.shortName.label?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

That's "Firefox Sync", we want it to just be "Sync".

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to :Gavin Sharp (email [e-mail]) from comment #3)
> That's "Firefox Sync", we want it to just be "Sync".

I was wrong!

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8368394 [details] [diff] [review]
patch

Review of attachment 8368394 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/260266bdf0ca

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/260266bdf0ca