Closed Bug 966175 Opened 6 years ago Closed 6 years ago

NetworkUtils sends wrong message to netd in setQuota function

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
1.3 C3/1.4 S3(31jan)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: albert, Assigned: dimi)

References

Details

(Keywords: regression)

Attachments

(2 files)

NetworkStats alarms stop working since net worker rewrite bug 864931 landed because wrong long long integer assignation in setQuota.

From logcat:

D/NetworkUtils(  134): Sending 'bandwidth setiquota rmnet0 0' command to netd.
E/BandwidthController(  135): Invalid bytes value. 1..max_int64.
D/NetworkUtils(  134): Receiving "bandwidth setiquota rmnet0 0" command response from netd.
D/NetworkUtils(  134):           ==> Code: 400  Reason: Bandwidth command failed
Assignee: nobody → acperez
Keywords: regression
Attached patch PatchSplinter Review
Attachment #8368417 - Flags: review?(vchang)
Blocks: 858017
Comment on attachment 8368417 [details] [diff] [review]
Patch

Review of attachment 8368417 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Albert, thanks for you help to fix this. Happy Chinese Year !!!
Attachment #8368417 - Flags: review?(vchang) → review+
Happy horse new year! :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/340f43a32a7a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
This should be 1.3t blocker.
blocking-b2g: --- → 1.3T?
Blocks: 864931
blocking-b2g: 1.3T? → 1.3T+
Assignee: acperez → dlee
You need to log in before you can comment on or make changes to this bug.