NetworkUtils sends wrong message to netd in setQuota function

RESOLVED FIXED in Firefox OS v1.3T

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: albert, Assigned: dimi)

Tracking

({regression})

unspecified
1.3 C3/1.4 S3(31jan)
ARM
Gonk (Firefox OS)
regression
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
NetworkStats alarms stop working since net worker rewrite bug 864931 landed because wrong long long integer assignation in setQuota.

From logcat:

D/NetworkUtils(  134): Sending 'bandwidth setiquota rmnet0 0' command to netd.
E/BandwidthController(  135): Invalid bytes value. 1..max_int64.
D/NetworkUtils(  134): Receiving "bandwidth setiquota rmnet0 0" command response from netd.
D/NetworkUtils(  134):           ==> Code: 400  Reason: Bandwidth command failed
(Reporter)

Updated

4 years ago
Assignee: nobody → acperez
(Reporter)

Updated

4 years ago
Keywords: regression
(Reporter)

Comment 1

4 years ago
Created attachment 8368417 [details] [diff] [review]
Patch
Attachment #8368417 - Flags: review?(vchang)
(Reporter)

Updated

4 years ago
Blocks: 858017
Comment on attachment 8368417 [details] [diff] [review]
Patch

Review of attachment 8368417 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Albert, thanks for you help to fix this. Happy Chinese Year !!!
Attachment #8368417 - Flags: review?(vchang) → review+
(Reporter)

Comment 3

4 years ago
Happy horse new year! :)
(Reporter)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/340f43a32a7a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
This should be 1.3t blocker.
blocking-b2g: --- → 1.3T?

Updated

4 years ago
Blocks: 864931
blocking-b2g: 1.3T? → 1.3T+
status-b2g-v1.3T: --- → ?
(Assignee)

Updated

4 years ago
Assignee: acperez → dlee
(Assignee)

Comment 7

4 years ago
Created attachment 8373953 [details] [diff] [review]
Bug 966175 fix for 1.3t

Updated

4 years ago
status-b2g-v1.3T: ? → affected
You need to log in before you can comment on or make changes to this bug.