966201 - There's a 1px top border between selected and non-selected items in the style editor stylesheets list

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

This doesn't appear in any of our other sidebar menus, when items are selected.

Comment 1

[Brian Grinstead [:bgrins]]

I'll take care of this - going to use the same code for the separators that is in use for side menu widget so it is the exact same as the other lists

Comment 2

[Brian Grinstead [:bgrins]]

I'm also noticing an issue with the dark theme where the active item spills into the editor gutter.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-list.patch

This updates the styling to more closely match the side menu widget.  Still don't know about the issue with the active dark item spilling over into the gutter (screenshot incoming).

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-lists.png

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: theme-splitview.patch

This patch resolves the overflowing issue with the dark theme, and fixes the original border issue in the light theme.  I've pulled in a lot of the styles from the side menu widget.  It isn't exactly the same though, since the markup is a bit different.  In order to get the right border that doesn't show up above the active arrow, I've removed the box shadow and added a third background image that is a 1px gradient on the edge matching the splitter color).

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 8370298 [details] [diff] [review]
theme-splitview.patch

Review of attachment 8370298 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/splitview.css
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +%filter substitution
> +%define smw_selectionTextColor #f5f7fa

Let's not have a smw_selectionTextColor variable, since it's just a standard color, and we don't have any variables anywhere yet for colors straight from the devtools palette.

Comment 7

[Brian Grinstead [:bgrins]]

Attachment: theme-splitview.patch

Just removed extra variable

Comment 8

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/db52e420fe23
https://tbpl.mozilla.org/?tree=Fx-Team&rev=db52e420fe23

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db52e420fe23