Closed
Bug 966205
Opened 10 years ago
Closed 10 years ago
Success callback could be invoked two times in the fb_data_reader module when datastore is readonly
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C3/1.4 S3(31jan)
People
(Reporter: jmcf, Assigned: jmcf)
Details
Attachments
(1 file)
https://github.com/mozilla-b2g/gaia/blob/master/shared/js/fb/fb_data_reader.js#L407 should not be called as https://github.com/mozilla-b2g/gaia/blob/master/shared/js/fb/fb_data_reader.js#L411 will always be executed as per promise chaining.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8368468 -
Flags: review?(crdlc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8368468 [details]
15858.html
Good catch!, thx
Attachment #8368468 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/73501dbfad4fd5b44cece04cafbc1931616f4161
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
|
||
Comment 4•10 years ago
|
||
Should this be uplifted to 1.3?
|
|
Assignee | |
Comment 5•10 years ago
|
||
I don't think so as in v1.3 we don't have any app that uses datastore in readonly mode.
You need to log in
before you can comment on or make changes to this bug.
Description
•