966228 - Email notification with no subject displays subject as 'null'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Comment 2

[robert.sajdok]

Attachment: screenshot

The behaviour is different on the latest version of the Gaia. The string "null" does not exist instead there is nothing. Should we still set the string "no subject" in order to fix this bug?

Comment 3

[James Burke [:jrburke]]

Robert: That sounds good. While there is an existing message-no-subject l10n key, I suggest you create a new one specific for notifications, with a LOCALIZATION NOTE with some background on where it was used. If you are up for taking the bug, feel free to assign it to yourself. I should be able to provide quick turnaround on review.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

I think we have a better bug on this with all of the l10n debate and everything.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Sorry, ran off to dinner.  The bug I was referring to was bug 1087819.  Remembering that bug more now, I do think it makes sense to keep this bug for the purposes :jrburke described in comment 3 and that bug can address the underlying ActiveSync issue or fancy errors in tests, etc.

Comment 6

[robert.sajdok]

Attachment: Proposed fix

Comment 7

[James Burke [:jrburke]]

Comment on attachment 8556656 [details] [review]
Proposed fix

This is the right approach, I just want a key name change, mentioned in pull request. Flip review back when done and I can r+ and merge.

Comment 8

[James Burke [:jrburke]]

Comment on attachment 8556656 [details] [review]
Proposed fix

Apologies for one more nit, as the style rules around the locale files are likely not well-defined: let's keep the LOCALIZATION_NOTE comment line to 80 characters. While the actual key value pairs might not fit within that, generally we want the comments to fit that to match other the line length used in other files, like the javascript styles. It should be good to go after that.

Comment 9

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/e0ff90ef6628c6fbf74e56110ae1c94b0cc61a9a

from pull request:
https://github.com/mozilla-b2g/gaia/pull/27791