[Session Restore] Shutdown blocker doesn't work

RESOLVED FIXED in Firefox 28

Status

()

defect
--
major
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

(Blocks 1 bug, {dataloss})

27 Branch
Firefox 29
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox27 wontfix, firefox28 fixed, firefox29 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Assignee: nobody → dteller
Attachment #8368539 - Flags: review?(ttaubert)
Whiteboard: [mentor=Yoric][lang=js]
Comment on attachment 8368539 [details] [diff] [review]
Fixing SessionFile blocker

Review of attachment 8368539 [details] [diff] [review]:
-----------------------------------------------------------------

Great find, we should make sure to get this into Fx 28+29. Actually, it would need to go into Fx 27 as well, which isn't going to happen...
Attachment #8368539 - Flags: review?(ttaubert) → review+
Version: unspecified → 27 Branch
Severity: normal → major
Comment on attachment 8368539 [details] [diff] [review]
Fixing SessionFile blocker

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 914581
User impact if declined: Possible sessionstore dataloss during shutdown.
Testing completed (on m-c, etc.): None, but it's a one-liner patch fixing a typo.
Risk to taking this patch (and alternatives if risky): None.
String or IDL/UUID changes made by this patch: None.
Attachment #8368539 - Flags: approval-mozilla-beta?
Attachment #8368539 - Flags: approval-mozilla-aurora?
Comment on attachment 8368539 [details] [diff] [review]
Fixing SessionFile blocker

It is indeed to late for 27 (currently the beta branch) but no worries for aurora.
(coucou David ;)
Attachment #8368539 - Flags: approval-mozilla-beta?
Attachment #8368539 - Flags: approval-mozilla-beta-
Attachment #8368539 - Flags: approval-mozilla-aurora?
Attachment #8368539 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/integration/fx-team/rev/2b69d9881038

Any way to test this?
Flags: in-testsuite?
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Ryan: Right now, I can't think of any.
https://hg.mozilla.org/mozilla-central/rev/2b69d9881038
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
David, does this have steps to reproduce that QA can use to verify this is fixed?
Flags: needinfo?(dteller)
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> David, does this have steps to reproduce that QA can use to verify this is
> fixed?

I can't think of anything reliable, I'm afraid.
Flags: needinfo?(dteller)
(In reply to David Rajchenbach Teller [:Yoric] (please use "needinfo?") from comment #10)
> (In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> > David, does this have steps to reproduce that QA can use to verify this is
> > fixed?
> 
> I can't think of anything reliable, I'm afraid.

Okay, thank you.
Whiteboard: [qa-]
What are the practical effects of this bug?
Flags: needinfo?(dteller)
The effect is that we might not wait for the SessionWorker to finish writing on shutdown. Which in turn might lead to data loss if there's data that hasn't made it to disk yet.
In the worst case, we might end up with:
- a session store representing the browsing state as it was ~15 seconds ago;
- some intriguing console warnings.
Flags: needinfo?(dteller)
You need to log in before you can comment on or make changes to this bug.