966481 - [notifications] object passed to navigator.mozSetMessageHandler('notification') does not have .close

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[James Burke [:jrburke]]

Attachment: Example app, unzip and add to gaia/apps and push to device

If a notification is passed to an app vi navigator.mozSetMessageHandler('notification'), the notification message does not a .close method.

The attached .zip file is a sample project that demonstrates the issue.

This affects the email app, since the changes with bug 890440, apps using the new notification API are expected to manage their own notifications. 

However, if the app has closed since sending the notification, the common scenario for email background sync, when the user clicks on the notification to start the app, and the email app receives the notification trigger via navigator.mozSetMessageHandler('notification'), that notification cannot be closed through that pathway.

This is only a 1.4 or later issue, does not affect 1.3.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Yeah, unfortunately the system message that gets passed to the notification handler only contains a copy of the data from the notification, and does not contain a notification object itself. For now, the workaround is to call Notification.get(), and close the notification returned from there. However, it sounds like a nice feature to have a close function on the system message. Other handlers for mozSetMessageHandler contain the actual object in question (like SMS for instance), but unfortunately passing an actual notification object would require much more work than just exposing '.close'.

Comment 2

[Julien Wajsberg [:julienw]]

Michael> that would mean basically calling "get" behind the scene? Is it really something that difficult? (besides the fact that the whole "get" implementation needs to be redone from scratch ;) )

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Michael> that would mean basically calling "get" behind the scene? Is it
> really something that difficult? (besides the fact that the whole "get"
> implementation needs to be redone from scratch ;) )

Unless I'm mistaken, the system message originates in the parent, and so calling Notification.get() from there will not yield the app's notification until we fix bug 874364 (which will give us a special API for fetching notifications across origins/apps).

Comment 4

[Julien Wajsberg [:julienw]]

Then maybe we can depend on bug 874364 here ?

Comment 5

[BMO Automation]

Firefox OS is not being worked on