966489 - Google Phone Search listing displays browser package name

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

See screenshot.

Anyone else see them as package names?

Comment 1

[Aaron Train [:aaronmt]]

This was from a Galaxy SII (Android 4.2)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Same on Gingerbread

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Same on Gingerbread

I lied. Gingerbread is fine.

Android 4.3 shows the package names

Comment 4

[Josh Dover [:jdover]]

Attachment: Use string resource for display name to match searchable

Looks like it was probably a regression caused by bug 923519. According to Android's docs, the *value* for android:label on searchable.xml must match the activity and application labels, thus they must be pointing to the same string resource.

Comment 5

[Josh Dover [:jdover]]

Docs for reference: http://developer.android.com/training/search/setup.html#create-sc

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8375973 [details] [diff] [review]
Use string resource for display name to match searchable

Assuming you tested this and verified the fix already. Both @MOZ_APP_DISPLAYNAME@ and @string/moz_app_displayname should evaluate to the same string, so that's pretty obnoxious that Android is this strict. Nice find!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/db83824a62a7

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db83824a62a7