Open
Bug 966517
Opened 11 years ago
Updated 2 years ago
Move email verification polling code into separate module
Categories
(Firefox :: Firefox Accounts, defect, P5)
Firefox
Firefox Accounts
Tracking
()
NEW
People
(Reporter: ttaubert, Unassigned)
References
Details
Attachments
(1 file)
|
21.21 KB,
patch
|
markh
:
feedback+
|
Details | Diff | Splinter Review |
FxAccounts.jsm is getting really bloated and somewhat unmaintainable. I think we should start moving code out of it into dedicated modules with simpler APIs. This would make writing tests also somewhat easier.
What do you think about that, Mark?
Attachment #8368904 -
Flags: feedback?(mhammond)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8368904 [details] [diff] [review]
0001-Bug-Move-email-verification-code-into-separate-modul.patch
Review of attachment 8368904 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/fxaccounts/FxAccounts.jsm
@@ +7,5 @@
> const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
>
> Cu.import("resource://gre/modules/Log.jsm");
> Cu.import("resource://gre/modules/Promise.jsm");
> +Cu.import("resource://gre/modules/Timer.jsm");
I'm surprised this can't be removed.
Attachment #8368904 -
Flags: feedback?(mhammond) → feedback+
|
||
Updated•10 years ago
|
Component: Sync → FxAccounts
Product: Firefox → Core
|
||
Updated•8 years ago
|
Priority: -- → P5
|
||
Updated•7 years ago
|
Product: Core → Firefox
|
||
Comment 2•6 years ago
|
||
Hey,Is this issue open? Can I work on this? Need help!
Flags: needinfo?(markh)
|
|
||
Comment 3•6 years ago
|
||
(In reply to komalbharadiya from comment #2)
Hey,Is this issue open? Can I work on this? Need help!
Sure! Feel free to put up a patch for comment, or to ask for any help you might need.
Flags: needinfo?(markh)
|
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•