966517 - Move email verification polling code into separate module

Status: NEW

(Firefox :: Firefox Accounts, defect, P5)

Description

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-Move-email-verification-code-into-separate-modul.patch

FxAccounts.jsm is getting really bloated and somewhat unmaintainable. I think we should start moving code out of it into dedicated modules with simpler APIs. This would make writing tests also somewhat easier.

What do you think about that, Mark?

Comment 1

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Comment on attachment 8368904 [details] [diff] [review]
0001-Bug-Move-email-verification-code-into-separate-modul.patch

Review of attachment 8368904 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/fxaccounts/FxAccounts.jsm
@@ +7,5 @@
>  const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
>  
>  Cu.import("resource://gre/modules/Log.jsm");
>  Cu.import("resource://gre/modules/Promise.jsm");
> +Cu.import("resource://gre/modules/Timer.jsm");

I'm surprised this can't be removed.

Comment 2

[komalbharadiya]

Hey,Is this issue open? Can I work on this? Need help!

Comment 3

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

(In reply to komalbharadiya from comment #2)

Hey,Is this issue open? Can I work on this? Need help!

Sure! Feel free to put up a patch for comment, or to ask for any help you might need.