966568 - Prevent sync notification bar from appearing when there is a token authentication error with the storage server

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Chris Karlof [:ckarlof]]

Tokens are expected to be short-lived (e.g., 5 mins), so this auth error will be routine. The code currently automatically recovers from this error, but it briefly shows the notification bar. The current workaround in place is to make browserid_identity.js believe the lifetime of the token is 80% of what it actually is, which causes it to refresh the token significantly before it expires, preventing the notification bar from appearing. The fix is to revisit when the notification bar appears and prevent it from appearing during these routine and recoverable storage auth failures.

Comment 1

[Julien Vehent]

It's been 2 years: can this be reverted back to normal?

Comment 2

[Chris Karlof [:ckarlof]]

We are working on fixing how error notification bars work. Do have a specific concern?

Comment 3

[Ryan Kelly [:rfkelly]]

This was fixed in a sense, by completely removing all the sync notification bars.  So I think we can safely close it.