Closed
Bug 966660
Opened 12 years ago
Closed 12 years ago
Remove inspect-button.png
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 30
People
(Reporter: ntim, Assigned: bgrins)
Details
Attachments
(1 file)
|
11.56 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Now that the highlighter is remote, we should remove inspect-button.png as we now use command-pick.png
| Reporter | ||
Updated•12 years ago
|
Flags: needinfo?(pbrosset)
Comment 1•12 years ago
|
||
Also there is a bit of css in inspector.css (in the 3 themes) that needs removing:
#inspector-inspect-toolbutton {
list-style-image: url("chrome://browser/skin/devtools/inspect-button.png");
-moz-image-region: rect(0px 16px 16px 0px);
}
#inspector-inspect-toolbutton[checked=true] {
-moz-image-region: rect(0px 32px 16px 16px);
}
Flags: needinfo?(pbrosset)
| Assignee | ||
Comment 2•12 years ago
|
||
Patrick, here is a patch that removes the images, and references from the jar.mn and CSS files. Ongoing try push: https://tbpl.mozilla.org/?tree=Try&rev=58848c65a09f
Assignee: nobody → bgrinstead
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8369465 -
Flags: review?(pbrosset)
Updated•12 years ago
|
Attachment #8369465 -
Flags: review?(pbrosset) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/643340a0b694
https://tbpl.mozilla.org/?tree=Fx-Team&rev=643340a0b694
Whiteboard: [fixed-in-fx-team]
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•