Closed Bug 966763 Opened 8 years ago Closed 8 years ago

Support for instance type changes for aws_watch_pending.py

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

Details

Attachments

(1 file)

In case if we want to change instance types...
Attachment #8369197 - Flags: review?(catlee)
Comment on attachment 8369197 [details] [diff] [review]
change_instance_type-cloud-tools-1.diff

Review of attachment 8369197 [details] [diff] [review]:
-----------------------------------------------------------------

r+, with MOAR LOGGING

::: aws/aws_watch_pending.py
@@ +246,5 @@
> +                new_instance_type = instance_type_changes.get(
> +                    i.region.name, {}).get(moz_instance_type)
> +                if new_instance_type and new_instance_type != i.instance_type:
> +                    i.connection.modify_instance_attribute(
> +                        i.id, "instanceType", new_instance_type)

this should be logged!
Attachment #8369197 - Flags: review?(catlee) → review+
Comment on attachment 8369197 [details] [diff] [review]
change_instance_type-cloud-tools-1.diff

with moar logging!
https://hg.mozilla.org/build/cloud-tools/rev/dbaaea103a9b
Attachment #8369197 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.