Closed
Bug 966763
Opened 11 years ago
Closed 11 years ago
Support for instance type changes for aws_watch_pending.py
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
Details
Attachments
(1 file)
|
7.04 KB,
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
In case if we want to change instance types...
Attachment #8369197 -
Flags: review?(catlee)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8369197 [details] [diff] [review]
change_instance_type-cloud-tools-1.diff
Review of attachment 8369197 [details] [diff] [review]:
-----------------------------------------------------------------
r+, with MOAR LOGGING
::: aws/aws_watch_pending.py
@@ +246,5 @@
> + new_instance_type = instance_type_changes.get(
> + i.region.name, {}).get(moz_instance_type)
> + if new_instance_type and new_instance_type != i.instance_type:
> + i.connection.modify_instance_attribute(
> + i.id, "instanceType", new_instance_type)
this should be logged!
Attachment #8369197 -
Flags: review?(catlee) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8369197 [details] [diff] [review]
change_instance_type-cloud-tools-1.diff
with moar logging!
https://hg.mozilla.org/build/cloud-tools/rev/dbaaea103a9b
Attachment #8369197 -
Flags: checked-in+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•