966831 - [User story] Add camera resolution to the camera settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Comment 1

[Youngjun Kim]

Prasad! Please check the user stories and update the current status.

Comment 2

[Leo]

Current status of Implementation:
1. Changing Image resolution based on the resolution value selected from setting menu - Done and Tested
2. Updating preview size with respective to the aspect ratio of Image resolution - under progress

Comment 3

[Jyothiprasad]

Attachment: Pointer to Pull Request.html

Hi David,
We made changes to the preview size when an image size is selected from settings Menu.
As this is work in progress patch, we did not include test code.

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8379679 [details]
Pointer to Pull Request.html

Adding Diego and Wilson

Comment 5

[Wilson Page [:wilsonpage]]

We too have implemented this functionality. As this has always been marked as a Mozilla item, and is tightly coupled to the evolving settings framework, I suggest we use the Mozilla implementation.

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8379679 [details]
Pointer to Pull Request.html

Clearing the review request based on comment #5.

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8379679 [details]
Pointer to Pull Request.html

This patch is now obsolete.

Comment 8

[Diego Marcos [:dmarcos]]

This is being implemented as part of bug 980599 (Currently under review)

Comment 9

[Diego Marcos [:dmarcos]]

Landed as part of bug 980599

Comment 10

[Hema Koka [:hema]]

flagging for ux reviews - feature landed on "camera-new-features" branch only as 3/17

Comment 11

[Tiffanie Shakespeare [:tif]]

I'm not sure what the issue is - I'm syncing the "camera-new-features" branch, but I'm not seeing any resolution options in the settings menu.

Comment 12

[Wilson Page [:wilsonpage]]

tiffanie: We have removed resolution options from the Mozilla camera in an attempt to simplify the camera experience and reduce the number of possible state combinations the camera can get into. I believe the Madai camera may choose to still expose this setting.

Comment 13

[Amy Lee [:amylee] UX]

Hi Youngjun,

Can you have someone attach a link to the patch for camera/video resolution settings if it is in the Madai camera? 

Thanks!

Comment 14

[Tiffanie Shakespeare [:tif]]

Wilson: totally makes sense, thanks :)

Hopefully we can get a patch or screenshots of the Madai version so we can close out the need info request.

Comment 15

[Youngjun Kim]

(In reply to Amy from comment #13)
> Hi Youngjun,
> 
> Can you have someone attach a link to the patch for camera/video resolution
> settings if it is in the Madai camera? 
> 
> Thanks!

Dear Amy,

We will provide MADAI version to you for ux review today via email.

Thank you.

Comment 16

[Tiffanie Shakespeare [:tif]]

I'm look at the dual-shutter branch in Hyunacho's repo. Please let me know if this is incorrect.

My two comments would be:
- the title of the camera resolution sub-menu should be title case (i.e. Camera Resolution)
- we should use a lower case x instead of the symbol that is being used (e.g. 2592x1944)

Comment 17

[David Flanagan [:djf]]

This bug is closed and the attachment that was here is obsolete. There isn't anything to uplift to 1.4 here as far as I can tell.

Comment 18

[David Flanagan [:djf]]

Removing the 1.4+ flag since there is nothing here to uplift