Closed
Bug 966835
Opened 11 years ago
Closed 11 years ago
[User story] Add HDR to camera settings
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed)
People
(Reporter: skasetti, Assigned: singhashish1887)
References
Details
(Whiteboard: [fxos:media])
User Story
1. As a user, I want to set HDR to on, off or auto in my camera settings menu 2. As a user, when I set HDR setting to either on, off or auto that setting is retained until I change it again Acceptance Criteria: 1. The user can find the HDR option in the camera settings menu 2. Tapping the HDR button should toggle to one of the 3 states:on, off or auto 3. After the user selects an option he/she can get back to the viewfinder with a status message indicating the HDR option 4. The selected option should persist until the user changes the option again
Attachments
(2 files, 4 obsolete files)
No description provided.
Reporter | ||
Updated•11 years ago
|
User Story: (updated)
Comment 1•11 years ago
|
||
Ashish! Please check the user stories and update the current status.
Assignee: nobody → singhashish1887
Assignee | ||
Comment 2•11 years ago
|
||
Once Gecko API is available we will implemente HDR.
Comment 3•11 years ago
|
||
In the latest version of the spec, this will not be a toggle but instead bring up a sub-menu of settings.
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8382613 -
Flags: review?(wilsonpage)
Comment 5•11 years ago
|
||
Comment on attachment 8382613 [details] [review]
Pull Request (camera-dev)
This needs to be amended to configure the application settings once we have got the camera capabilities back.
Attachment #8382613 -
Flags: review?(wilsonpage) → review-
Comment 6•11 years ago
|
||
Ammended and landed on dmarcos/camera-dev-rebased
Comment 8•11 years ago
|
||
Attachment #8385846 -
Flags: review?(dflanagan)
Updated•11 years ago
|
Flags: needinfo?(jdarcangelo)
Comment 9•11 years ago
|
||
Comment on attachment 8385846 [details] [review]
pull-request (camera-new-features)
This looks good overall, but I'm giving r- because we need a way to disable HDR even on devices that support it. If we find it causes regressions we need to be able to turn it off. And if we have to run on a device that claims to have HDR support, but the pictures look terrible, we'll want to turn it off.
So we need a boolean enableHDR property (or something like that) in config/app.js HDR should only appear in settings and as an indicator if it is both enabled in settings and if the hardware capabilities say it is supported.
Also: are the UX issues around HDR and flash mode sorted out? If so, it would be nice to implement all of that here in the same pull request. (If that is still being figured out, I'm willing to land the flash-related changes in a separate PR, however.)
Setting needinfo for Ashish to be sure he sees this.
Attachment #8385846 -
Flags: review?(dflanagan) → review-
Flags: needinfo?(singhashish1887)
Comment 10•11 years ago
|
||
"we need a way to disable HDR even on devices that support it"
This is already possible by removing it from the `settingsMenu` setting in config/app.js
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #8387485 -
Flags: review?(wilsonpage)
Flags: needinfo?(singhashish1887)
Comment 12•11 years ago
|
||
Comment on attachment 8387485 [details] [review]
Pull Request (camera-dev)
Comments left on Github
Summary:
- Make use of flashModes settings alias
- Use event listeners to change hdr and flashModes instead of bundling logic inot existing funnctions
- Unit tests required
Attachment #8387485 -
Flags: review?(wilsonpage) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #8387485 -
Attachment is obsolete: true
Assignee | ||
Comment 13•11 years ago
|
||
Updated as per Wilson's comments .Open for review
Attachment #8388011 -
Flags: review?(wilsonpage)
Assignee | ||
Updated•11 years ago
|
Attachment #8388011 -
Attachment is obsolete: true
Attachment #8388011 -
Flags: review?(wilsonpage)
Assignee | ||
Comment 14•11 years ago
|
||
As per Wilson's comment we have changed the HDR flash changes on events
Attachment #8388996 -
Flags: review?(wilsonpage)
Assignee | ||
Comment 15•11 years ago
|
||
Unit test codes are also updated .
Assignee | ||
Updated•11 years ago
|
Attachment #8388996 -
Attachment is obsolete: true
Attachment #8388996 -
Flags: review?(wilsonpage)
Assignee | ||
Comment 16•11 years ago
|
||
Attachment #8390426 -
Flags: review?(wilsonpage)
Attachment #8390426 -
Flags: review?(dflanagan)
Assignee | ||
Updated•11 years ago
|
Attachment #8382613 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #8390426 -
Flags: review?(wilsonpage)
Attachment #8390426 -
Flags: review?(dflanagan)
Attachment #8390426 -
Flags: review+
Comment 17•11 years ago
|
||
Landed on mozilla/camera-new-features: https://github.com/mozilla-b2g/gaia/commit/d1d28fdd2386764029cc078c48f0d9274ef26217
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 18•11 years ago
|
||
flagging for ux review
Flags: needinfo?(tshakespeare)
Flags: needinfo?(amlee)
Comment 19•11 years ago
|
||
Amy and I discussed and she's posting more details. High level is HDR icon and text when toggling is missing.
Flags: needinfo?(tshakespeare)
Comment 20•11 years ago
|
||
(In reply to Hema Koka [:hema] from comment #18)
> flagging for ux review
I've provided my feedback in Bug 976852 Comment 21
Flags: needinfo?(amlee)
Comment 21•11 years ago
|
||
Bulk edit for camera bugs.
If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.
This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
Updated•11 years ago
|
blocking-b2g: --- → 1.4+
You need to log in
before you can comment on or make changes to this bug.
Description
•