Closed Bug 966850 Opened 7 years ago Closed 7 years ago

screen.yahoo.com sniffing falls back to Flash, does not play video

Categories

(Web Compatibility :: Mobile, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hsteen, Assigned: karlcow)

References

()

Details

(Whiteboard: [mobile-compat-form][country-all][clientsniff][contactready][video])

Site: http://screen.yahoo.com
screen.yahoo.com sniffing falls back to Flash, does not play video

:: Steps To Reproduce

There's code like this in http://l.yimg.com/rx/builds/4.1.15.1390360235/videoplayer-min_ycs.js - couldn't some of that sniffing be replaced with canPlayType() calls?

        getFormatsAndProtocols: function(ak) {
            var Y, al;
            if ("html" === ak) {
                al = [H.protocols.HTTP];
                if (f.Lang.isNumber(f.UA.ios)) {
                    Y = [H.formats.M3U8, H.formats.MP4];
                }
                else {
                    if (f.Lang.isNumber(f.UA.android) && f.UA.android > 0) {
                        Y = [H.formats.WEBM, H.formats.MP4];
                        if (f.UA.chrome > 0) {
                            Y.push(H.formats.M3U8);
                        }
                        else {
                            Y.push("h264");
                            al.push(H.protocols.RTSP);
                        }
                    }
                    else {
                        if (f.UA.chrome > 0) {
                            Y = [H.formats.MP4, H.formats.WEBM];
                        }
                        else {
                            if (f.UA.safari > 0) {
                                Y = [H.formats.MP4, H.formats.M3U8];
                            }
                            else {
                                if ((f.Lang.isNumber(f.UA.gecko) && f.UA.gecko > 0) || f.UA.opera >= 10.6) {
                                    Y = [H.formats.WEBM];
                                }
                                else {
                                    Y = [H.formats.MP4];
                                }
                            }
                        }
                    }
                }
            }
            else {
                Y = [H.formats.MP4, H.formats.FLV, H.formats.F4M];
                al = [H.protocols.RTMP, H.protocols.HTTP];
            }
            return {
                formats: Y,
                protocols: al
            };
        }
    };


:: Expected Result

video

:: Actual Result

no video

:: Additional Information

Software Version: 1.1
Reporter's User Agent: Mozilla/5.0 (Mobile; rv:26.0) Gecko/26.0 Firefox/26.0
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [mobile-compat-form] → [mobile-compat-form][country-all][clientsniff][contactready]
Whiteboard: [mobile-compat-form][country-all][clientsniff][contactready] → [mobile-compat-form][country-all][clientsniff][contactready][video]
I'll try to get contacts at Yahoo!
Assignee: nobody → kdubost
Status: NEW → ASSIGNED
aaand it's fixed itself! Works in 1.4 on my Geeksphone peak!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(We also have a test for this that used to fail and now passes, it's a good test checking if the site creates <VIDEO> tags - so it seems they really changed something)
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.