966856 - Add SHA-2 support to mozilla::pkix's OCSP implementation

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

1. Make sure that SHA-2 hashes work in CertID
2. Test that SHA-2 signatures are accepted.
3. Ensure that we send the preferred signature algorithm extension in our OCSP requests (http://tools.ietf.org/html/rfc6960#section-4.4.7).

Comment 1

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: patch

I rebased this on top of bug 969048 since it's about to land (once bug 915932 lands and sticks, which it looks like it will), but the only conflict should be with the telemetry tests. One thing to note is that since bug 663315 hasn't been finished, sha-2 is not supported in NSS/classic verification.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

It will be a few days before I get to this. AFAICT, this is new functionality beyond the NSS-based verifier and I also want to write unit tests in bug 966856 for this.

Comment 3

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8390145 [details] [diff] [review]
patch

This has probably bit-rotted quite a bit. Clearing review until we need this.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Dana, is there any chance of this happening soon? I think it would be great if we started moving towards a world where you don't need to implement SHA-1 at all. This is the last place on, AFAICT, where SHA-1 is required, after servers upgrade to TLS 1.2 with SHA-2 based certs.

Comment 5

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

I'll see what I can do. I agree this would be a good thing to do.

Comment 6

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

I'm not actively working on this at the moment.

Comment 8

[Nathan Reed]

It appears that docs.microsoft.com has recently started using OCSP stapling with SHA-256, which is causing Firefox to give certificate errors when connecting to it, unless OCSP stapling is disabled (security.ssl.enable_ocsp_stapling preference).

It might be good to revisit the priority here - the Microsoft docs site is a pretty major one used by a lot of developers.

Comment 9

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: Bug 966856 - mozilla::pkix: support SHA-2 hashes in CertIDs in OCSP responses r?jschanck!,djackson!

Comment 10

[Pascal Gadient]

Seems like Microsoft forces the rollout to further domains: https://partner.microsoft.com/dashboard is also affected.

Comment 11

[manuforcen]

(In reply to Pascal Gadient from comment #10)

Seems like Microsoft forces the rollout to further domains: https://partner.microsoft.com/dashboard is also affected.

It is used also in Microsoft OneDrive and similar pages.

Comment 12

[Pascal Gadient]

Since it prevents Microsoft OneDrive, SharePoint and many other major web services from functioning properly, I recommend an urgent bug fix release to avoid that users have to switch to other browsers, which are compatible with those websites.

Comment 13

[ville.puntanen]

This also affect any websites using Bing Maps Ajax Web Control... Quick fix is needed.

Comment 14

[Dennis Schubert [:denschub]]

Hey folks -- we understand your frustration, but please do not use this bug to post "me too"s. We're aware of this problem and a fix is in development. Let's keep this bug as clean as possible so that the work on the fix can progress without interruptions. :)

Comment 15

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/7d4f221b1fffcad72b18175b89e4d310307277ef

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/nss/rev/78d2f4a3339fa41c274c5ea189f8060da9d3a463 (NSS_3_68_2_BRANCH)
https://hg.mozilla.org/projects/nss/rev/e8211cfc2b2d6f763febcf64c8c3caf6f9fe08d5 (NSS_3_72_1_BRANCH)
https://hg.mozilla.org/projects/nss/rev/69c5a0c748ad36772a3ce03c60f8a1fa353776dc (NSS_3_73_1_BRANCH)