966946 - Buttons don't display highlighted state on touchstart

Status: RESOLVED DUPLICATE of bug 819112

(Firefox for Metro Graveyard :: Theme, defect, P2)

Description

[Jim Mathies [:jimm]]

I'm pretty sure this is a missing feature in platform, although we could probably fix it in front end as well. When you tap down on a chrome button (say in an alert box), the button should highlight but doesn't. So button presses provide no user feedback.

Comment 1

[Neil Deakin]

The theme code handles both hover and active states. For the touchstart case, do either of these get set and which ones should be?

Comment 2

[Jim Mathies [:jimm]]

(In reply to Neil Deakin from comment #1)
> The theme code handles both hover and active states. For the touchstart
> case, do either of these get set and which ones should be?

I'm pretty sure it should be active, just like a mouse down. Currently this doesn't get set for touchstart AFAICT, there's no change in the button when you press down on it. Comparing that to mouse down behavior shows there is an active state defined. (I'm testing on alert()).

Comment 3

[Jim Mathies [:jimm]]

here's our styles for buttons:

http://mxr.mozilla.org/mozilla-central/source/browser/metro/theme/platform.css#57

Comment 4

[Matt Brubeck (:mbrubeck)]

The underlying core bug is bug 819112.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> The underlying core bug is bug 819112.

Would it be ok to fix this in front end similar to other platforms, or would that be considered a total cop out on the platform work (which sound kinda yucky). :)

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This might be subtly different from bug 819112 but it's close enough that I'm comfortable duping it given that Metro is no longer a thing.