UITour: showMenu("bookmarks") opens the submenu instead of the subview in the menu panel

NEW
Unassigned

Status

()

defect
P4
normal
6 years ago
5 years ago

People

(Reporter: zfang, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M-])

Opening discussion for opening the bookmarks panel in the step when we talk about bookmarks. 

The argument here was that it's more consistent with other steps in the tour and the page looks less empty. But the problem is we can't predict what's in the users bookmarks menu, they might have way too many bookmarks and it won't look pretty. But we can implement and test.
This is already implemented in-product with showMenu("bookmarks"). Shall we close this bug as WORKSFORME or move it to blocking a webdev bug?
Flags: needinfo?(zfang)
Whiteboard: [implemented in-product]
Awesome! We'll use it later but not for Aurora now. Can we leave this open for now and block a webdev bug just to keep track?
Flags: needinfo?(zfang)
When the bookmark widget is in the panel menu AND the menu panel is open, the panel is opened instead of the subview showing. It would be nice if this was fixed in the bookmark widget so it did the right thing but I haven't looked into that.
(In reply to Matthew N. [:MattN] from comment #3)
> the panel is opened instead of the subview showing.

I'm referring to the bookmark panel.
(In reply to Matthew N. [:MattN] from comment #3)
> When the bookmark widget is in the panel menu AND the menu panel is open,
> the panel is opened instead of the subview showing. It would be nice if this
> was fixed in the bookmark widget so it did the right thing but I haven't
> looked into that.

That's not what happens when you click it. What does the UITour code do to show the item?
https://mxr.mozilla.org/mozilla-central/source/browser/modules/UITour.jsm?rev=54d9feac4e7a&mark=703#694

We call showMenu(true) on the MenuBoxObject. I guess we may be able to just create click events instead.
(In reply to Matthew N. [:MattN] from comment #6)
> https://mxr.mozilla.org/mozilla-central/source/browser/modules/UITour.
> jsm?rev=54d9feac4e7a&mark=703#694
> 
> We call showMenu(true) on the MenuBoxObject. I guess we may be able to just
> create click events instead.

That or, less risky for Aurora, teach it to do something else when the button is in the panel...
Summary: UITour: Open Bookmarks panel when we talk about Bookmarks in the tour → UITour: showMenu("bookmarks") opens the submenu instead of the subview in the menu panel
Whiteboard: [implemented in-product]
Whiteboard: [Australis:M-]
Moving open UITour bugs to Firefox::Tours. Filter on firefox-tours-20150121.
Component: General → Tours
You need to log in before you can comment on or make changes to this bug.