Closed Bug 967007 Opened 10 years ago Closed 10 years ago

Bump the sniffing limit for mp3

Categories

(Core :: Audio/Video, defect, P1)

Product:
Core
Component:
Audio/Video
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30
Tracking Flags:
Tracking Status
firefox28 --- fixed
firefox29 + fixed
firefox30 + fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Bump the sniffing limit for mp3. r=
2.11 KB, patch
rillian
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
      No description provided.

        Attachment #8369462 -
        Flags: review?(giles)

    
    

    
  
It'd be great to get this landed and then uplifted into Aurora and Beta since this seems very low risk.
Priority: -- → P1
Blocks: 950023

    
    

    
  
Comment on attachment 8369462 [details] [diff] [review]
Bump the sniffing limit for mp3. r=

Review of attachment 8369462 [details] [diff] [review]:
-----------------------------------------------------------------

BTW, is there some reason to expect we'll have at least 1445 bytes available when we're called, or is sniffing just best-effort based on what's received when we PeekStream?

        Attachment #8369462 -
        Flags: review?(giles) → review+

    
    

    
  
Ralph, I think it's best effort, but it worked every single time in my testing.

https://hg.mozilla.org/integration/mozilla-inbound/rev/24c8afd3d881

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/24c8afd3d881
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

    
    

    
  
Should it be uplifted to aurora and beta?
Flags: needinfo?(paul)

    
    

    
  
Comment on attachment 8369462 [details] [diff] [review]
Bump the sniffing limit for mp3. r=

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 789123
User impact if declined: Some mp3 files (high-quality files) won't be sniffed as being mp3 files, and decoding will error out, especially (but not exclusively) when using Web Audio
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low, this is just a constant change
String or IDL/UUID changes made by this patch: none

        Attachment #8369462 -
        Flags: approval-mozilla-beta?

        Attachment #8369462 -
        Flags: approval-mozilla-aurora?
Flags: needinfo?(paul)

    
    

    
  
Comment on attachment 8369462 [details] [diff] [review]
Bump the sniffing limit for mp3. r=

thanks

        Attachment #8369462 -
        Flags: approval-mozilla-beta?

        Attachment #8369462 -
        Flags: approval-mozilla-beta+

        Attachment #8369462 -
        Flags: approval-mozilla-aurora?

        Attachment #8369462 -
        Flags: approval-mozilla-aurora+

    
  
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: