967032 - Intermittent testAdobeFlash | "Process crashed?" on tegra

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

Bug 722166 has various crashes and possible crashes in it. Some of the recent reports are for testAdobeFlash on tegra:

https://tbpl.mozilla.org/php/getParsedLog.php?id=33943766&full=1&branch=mozilla-inbound#error0

https://tbpl.mozilla.org/php/getParsedLog.php?id=33912035&full=1&branch=mozilla-inbound#error0

Robocop jobs that end very fast sometimes show this behavior. I think the issue is that the crashreporter has not been initialized before the test ends.

Suggestions for resolving this:
 - skip the test entirely on tegra (Android SDK 8) via robocop.ini
 - blockForGeckoReady in the test, at least on Tegra

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

We don't run the Flash tests on 2.2, so I think the presence of testAdobeFlash is a red herring. It looks like it failed to acquire a surface on startup.

Comment 2

[Geoff Brown [:gbrown]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #1)
> We don't run the Flash tests on 2.2, so I think the presence of
> testAdobeFlash is a red herring. It looks like it failed to acquire a
> surface on startup.

The Flash tests don't run, but testAdobeFlash is executed:

02-01 06:06:40.982 I/Robocop ( 2695): 0 INFO SimpleTest START
02-01 06:06:40.982 I/Robocop ( 2695): 1 INFO TEST-START | testAdobeFlash

I am pretty sure that the issue is that the test ends before gecko (and especially the crashreporter) is initialized -- see simple solutions in Comment 0.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Geoff Brown [:gbrown] from comment #2)
> (In reply to James Willcox (:snorp) ([e-mail]) from comment #1)
> > We don't run the Flash tests on 2.2, so I think the presence of
> > testAdobeFlash is a red herring. It looks like it failed to acquire a
> > surface on startup.
> 
> The Flash tests don't run, but testAdobeFlash is executed:
> 
> 02-01 06:06:40.982 I/Robocop ( 2695): 0 INFO SimpleTest START
> 02-01 06:06:40.982 I/Robocop ( 2695): 1 INFO TEST-START | testAdobeFlash
> 
> I am pretty sure that the issue is that the test ends before gecko (and
> especially the crashreporter) is initialized -- see simple solutions in
> Comment 0.

Indeed, I see that now. Eugen please try calling blockForGeckoReady() and see if that fixes things.

Comment 4

[Eugen Sawin [:esawin]]

Adding blockForGeckoReady() for pre 4.0 Android versions fixes the failed test locally and so far looks good on Try (https://tbpl.mozilla.org/?tree=Try&rev=36dca65b31cb), but the crash is not that frequently occurring there ( https://tbpl.mozilla.org/?tree=Try&rev=f882da366aea).

Comment 5

[Eugen Sawin [:esawin]]

Attachment: test-adobe-flash.patch

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8a2d8a022387

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a2d8a022387

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7a0efd712e25