967042 - mozprocess doesn't work with python 2.7.6 on Windows

Status: RESOLVED DUPLICATE of bug 950894

(Testing :: Mozbase, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I updated python to version 2.7.6 and am getting the following error when I use mach:

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: _execute_child() takes exactly 17 arguments (18 given)

  File "c:\mozbuild\src\mozilla-central\python/mozbuild/mozbuild/mach_commands.py", line 404, in build
    silent=not verbose, force_pymake=pymake)
  File "c:\mozbuild\src\mozilla-central\python/mozbuild\mozbuild\base.py", line 467, in _run_make
    return fn(**params)
  File "c:\mozbuild\src\mozilla-central\python/mozbuild\mozbuild\base.py", line 509, in _run_command_in_srcdir
    return self.run_process(cwd=self.topsrcdir, **args)
  File "c:\mozbuild\src\mozilla-central\python/mach\mach\mixin\process.py", line 126, in run_process
    p.run()
  File "c:\mozbuild\src\mozilla-central\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 640, in run
    self.proc = self.Process([self.cmd] + self.args, **args)
  File "c:\mozbuild\src\mozilla-central\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 96, in __init__
    universal_newlines, startupinfo, creationflags)
  File "c:\mozbuild\python\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
Exception AttributeError: "'Process' object has no attribute '_handle'" in <bound method Process.__del__ of <mozprocess.
processhandler.Process object at 0x02760330>> ignored

Comment 1

[Gregory Szorc [:gps]]

17 arguments?! This is a mozprocess / mozbase bug. They're playing with fire by calling internal APIs.

Comment 2

[Gregory Szorc [:gps]]

I'm running 2.7.6 on OS X and things work fine. Likely Windows only issue.

Comment 3

[Andrew Halberstadt [:ahal]]

This is already fixed upstream. Feel free to land the changes in bug 961235 on m-c if this is burning tbpl anywhere. Otherwise it'll get synced as part of bug 949600

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, this bug has not been fixed yet! But it's a dupe of bug 950894, which has a patch but no-one landed it yet.